Avoid className prop on NavigationItemsFilter

mongodb-js · Nov 13, 2024 · 207bbc1 · 207bbc1
1 parent 5e901dd
commit 207bbc1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 19 deletions.
diff --git a/packages/compass-sidebar/src/components/multiple-connections/connections-navigation.tsx b/packages/compass-sidebar/src/components/multiple-connections/connections-navigation.tsx
@@ -83,10 +83,6 @@ const connectionCountStyles = css({
   marginLeft: spacing[100],
 });
 
-const searchFormStyles = css({
-  flexGrow: 1,
-});
-
 const noDeploymentStyles = css({
   paddingLeft: spacing[400],
   paddingRight: spacing[400],
@@ -507,7 +503,6 @@ const ConnectionsNavigation: React.FC<ConnectionsNavigationProps> = ({
       {connections.length > 0 && (
         <>
           <NavigationItemsFilter
-            className={searchFormStyles}
             placeholder="Search connections"
             filter={filter}
             onFilterChange={onFilterChange}

diff --git a/packages/compass-sidebar/src/components/navigation-items-filter.tsx b/packages/compass-sidebar/src/components/navigation-items-filter.tsx
@@ -12,6 +12,10 @@ const filterContainerStyles = css({
   paddingRight: spacing[400],
 });
 
+const textInputStyles = css({
+  flexGrow: 1,
+});
+
 function createRegExp(input: string) {
   try {
     return input ? new RegExp(input, 'i') : null;
@@ -26,7 +30,6 @@ export default function NavigationItemsFilter({
   title = 'Search',
   filter,
   onFilterChange,
-  className,
 }: {
   placeholder?: string;
   ariaLabel?: string;
@@ -35,7 +38,6 @@ export default function NavigationItemsFilter({
   onFilterChange(
     updater: (filter: ConnectionsFilter) => ConnectionsFilter
   ): void;
-  className?: string;
 }): React.ReactElement {
   const onChange = useCallback<React.ChangeEventHandler<HTMLInputElement>>(
     (event) => {
@@ -55,23 +57,22 @@ export default function NavigationItemsFilter({
   }, []);
 
   return (
-    <div className={filterContainerStyles}>
-      <form noValidate className={className} onSubmit={onSubmit}>
-        <TextInput
-          data-testid="sidebar-filter-input"
-          placeholder={placeholder}
-          type="search"
-          aria-label={ariaLabel}
-          title={title}
-          onChange={onChange}
-        />
-      </form>
+    <form noValidate className={filterContainerStyles} onSubmit={onSubmit}>
+      <TextInput
+        data-testid="sidebar-filter-input"
+        placeholder={placeholder}
+        type="search"
+        aria-label={ariaLabel}
+        title={title}
+        onChange={onChange}
+        className={textInputStyles}
+      />
       <ConnectionsFilterPopover
         open={isPopoverOpen}
         setOpen={setPopoverOpen}
         filter={filter}
         onFilterChange={onFilterChange}
       />
-    </div>
+    </form>
   );
 }