chore(ci): use artifactory mirror as docker registry #6490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
the
no-title-validation
kraenhansen
force-pushed
the
kh/artifactory-docker-mirror
branch
3 times, most recently
from
942af52 to
af9655c
Compare
kraenhansen
force-pushed
the
kh/artifactory-docker-mirror
branch
from
af9655c to
e0857d2
Compare
addaleax
reviewed
Nov 14, 2024
| function atlascli() { | ||
| docker run \ | ||
| -e MCLI_PUBLIC_API_KEY \ | ||
| -e MCLI_PRIVATE_API_KEY \ | ||
| -e MCLI_ORG_ID \ | ||
| -e MCLI_PROJECT_ID \ | ||
| -e MCLI_OPS_MANAGER_URL \ | ||
| mongodb/atlas atlas $@ | ||
| $DOCKER_REGISTRY/library/mongodb/atlas atlas $@ |
There was a problem hiding this comment.
Random thought – would this be easier or harder to work with if we included /library/ in the env var value, so that the default would just end up being an empty string if nothing has been explicitly configured before?
|
Closing as it seems we'll be taking the route of authenticated requests to Docker Hub instead 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at unbreaking CI by using the artifactory mirror instead of dockerhub directly.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes