Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(e2e): Smoke test cli cleanup #6594

Merged
merged 4 commits into from
Jan 8, 2025
Merged

chore(e2e): Smoke test cli cleanup #6594

merged 4 commits into from
Jan 8, 2025

Conversation

kraenhansen
Copy link
Contributor

Description

None of my suggested changes are critical and I'd be okay with reverting any of the, if you have a strong preference for the existing code 👍

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen requested a review from lerouxb January 8, 2025 08:50
@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 8, 2025
@kraenhansen kraenhansen merged commit 21f515d into main Jan 8, 2025
29 of 33 checks passed
@kraenhansen kraenhansen deleted the kh/smoke-test-cli-cleanup branch January 8, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lerouxb lerouxb lerouxb approved these changes

Assignees
No one assigned
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @lerouxb