Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver-bench): add driver benchmarks to dbx-tools #11

Merged
merged 4 commits into from
May 23, 2024

Conversation

nbbeeken
Copy link
Collaborator

Description

What is changing?

  • Pulled over the benchmarks from the driver, keeping git history
  • Migrated to TS and mjs
  • Fixed TS issues
  • Added a small CLI script to make the benchmarks runnable.
Is there new documentation needed for these changes?

No

What is the motivation for this change?

I find myself comparing two copies of the driver a lot, with and without work-in-progress changes. Moving to a separate repo helps with making the benchmarks take a driver copy as an input. I would often make the change locally to accept a path as an ENV var but trample it when I needed to reset the driver to main.

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from baileympearson May 22, 2024 19:20
@baileympearson baileympearson merged commit 62dd17c into main May 23, 2024
4 checks passed
@baileympearson baileympearson deleted the chore-add-bench branch May 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants