chore(oidc): add docker compose configuration that uses mock oidc provider #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Dec 1, 2023
| // to localhost. To make sure that all responses returned by mock provider are | ||
| // matching the proxy address that is exposed outside, we override instance | ||
| // issuer property after we start the mock provider. | ||
| provider.issuer = `http://localhost:${proxyPort}`; |
There was a problem hiding this comment.
There is probably an easier way to achieve this, but this seems to work just fine
Anemy
approved these changes
Dec 1, 2023
| ```sh | ||
| mongosh \ | ||
| --host localhost \ | ||
| --port 27017 \ |
There was a problem hiding this comment.
How do you feel about using a different port than the default? That way it won't conflict with other testing environments we have. Maybe 27096?
There was a problem hiding this comment.
Makes sense (and your other comment too), let me update that!
Anemy
reviewed
Dec 1, 2023
…ripts; export env config
|
Updated. Also added export for this env to the default package export as this one doesn't require any special setup compared to the one using external oidc provider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is kinda hacky, but it works even on macos where we can't use host network and allows easier control over oidc provider response for testing purposes (it's the same as we use in e2e tests)