fix: allowConnectionsWithoutCertificates: true #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Mar 4, 2024
| @@ -7,6 +7,7 @@ net: | |||
| CAFile: /etc/mongod/tls/ca.pem | |||
| allowInvalidCertificates: true | |||
| allowInvalidHostnames: true | |||
| allowConnectionsWithoutCertificates: true | |||
There was a problem hiding this comment.
I'm not sure if it is needed here. I left it out of the x509 server config because those tests seem to succeed anyway.
There was a problem hiding this comment.
Adding this to the config where the server is expected X.509 auth would break the tests there, yeah
addaleax
approved these changes
Mar 4, 2024
| @@ -7,6 +7,7 @@ net: | |||
| CAFile: /etc/mongod/tls/ca.pem | |||
| allowInvalidCertificates: true | |||
| allowInvalidHostnames: true | |||
| allowConnectionsWithoutCertificates: true | |||
There was a problem hiding this comment.
Adding this to the config where the server is expected X.509 auth would break the tests there, yeah
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://jira.mongodb.org/browse/SERVER-72839?focusedCommentId=5678381&focusedId=5678381&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-5678381 and what mongosh' tests do it seems we need this because we're not specifying a certificate in the corresponding client connections/ tests.