chore: fix bin/mongodb-schema script #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Oct 25, 2023
|
We should probably convert that script to typescript, but I don't think anyone uses it. It is sometimes handy for testing locally, though. |
lerouxb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample option wasn't working because mongodb-collection-sample's returned stream wasn't iterating. I switched it to using a sample aggregation and now that dep can be gone from our dependencies here and in compass.
The repeat argument wasn't doing anything.
This is much simpler with just async iterators over the cursor we get when either doing a find or a sample aggregation.
The schemaStats functions weren't working because the export is now the
defaultobject.We weren't using the new analyzer methods.