Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): use a different release process when publishing auxiliary packages #2319

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Jan 15, 2025

Some refactoring to make it different scenarios clearer and use a different function when just publishing auxiliary packages.
We should just be publishing to npm in this case (and let lerna push tags).

@gagik gagik added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 15, 2025
@gagik gagik force-pushed the gagik/different-release-path branch from 2a4aa5b to d17b88f Compare January 15, 2025 12:04
@gagik gagik requested review from addaleax and nirinchev January 15, 2025 12:05
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small bit of feedback I'd have is that the commit message here could be used to explain what didn't work with the previous approach/how exactly this approach differs from it 🙂

@gagik gagik merged commit abe83bb into main Jan 15, 2025
115 of 119 checks passed
@gagik gagik deleted the gagik/different-release-path branch January 15, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants