Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: identify a namespace to place in generated query VSCODE-579 #778

Merged
merged 22 commits into from
Aug 16, 2024
Merged

feat: identify a namespace to place in generated query VSCODE-579 #778

merged 22 commits into from
Aug 16, 2024

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 14, 2024 •
edited
Loading

Description

  • Select a connection from the participant VSCODE-577
  • Select a namespace from the participant VSCODE-579
  • Replace connected/disconnected messages in modals with status view messages #379
  • Add the allowed Shell commands to the query prompt VSCODE-576 (Do not close the ticket, more work needs to be done)

The alternative solution to connect via the button in the chat response that opens the command palette was explored here.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika marked this pull request as ready for review August 15, 2024 16:16
@alenakhineika alenakhineika removed the WIP label Aug 16, 2024
@alenakhineika alenakhineika added WIP and removed WIP labels Aug 16, 2024
@alenakhineika alenakhineika removed the WIP label Aug 16, 2024
Anemy
Anemy reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things I noticed, let's sync online

src/connectionController.ts Outdated Show resolved Hide resolved
src/participant/prompts/query.ts Outdated Show resolved Hide resolved
src/participant/prompts/query.ts Outdated Show resolved Hide resolved
Anemy
Anemy approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, not blockers.

src/connectionController.ts Outdated Show resolved Hide resolved
src/participant/prompts/namespace.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika merged commit 563a8ce into VSCODE-528-mongodb-copilot Aug 16, 2024
3 checks passed
@alenakhineika alenakhineika deleted the VSCODE-579-identify-namespace branch August 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anemy Anemy Anemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @Anemy