fix: skip direct OpenSSL API interaction for certificate conversion #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron does not expose its bundled SSL library to users, unlike Node.js (which is probably reasonable, considering that it uses BoringSSL, which will generally have different ABI properties than OpenSSL). As a consequence, building this addon for Electron fails currently.
However, there is an easier solution available now that I overlooked; the X509Certificate class available since Node.js 15.6.0 supports direct conversion from DER to PEM as well, so no native interactions with the OpenSSL API are actually necessary these days.