Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip direct OpenSSL API interaction for certificate conversion #5

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

addaleax
Copy link
Contributor

Electron does not expose its bundled SSL library to users, unlike Node.js (which is probably reasonable, considering that it uses BoringSSL, which will generally have different ABI properties than OpenSSL). As a consequence, building this addon for Electron fails currently.

However, there is an easier solution available now that I overlooked; the X509Certificate class available since Node.js 15.6.0 supports direct conversion from DER to PEM as well, so no native interactions with the OpenSSL API are actually necessary these days.

Electron does not expose its bundled SSL library to users, unlike
Node.js (which is probably reasonable, considering that it uses
BoringSSL, which will generally have different ABI properties than
OpenSSL). As a consequence, building this addon for Electron fails
currently.

However, there is an easier solution available now that I overlooked;
the X509Certificate class available since Node.js 15.6.0 supports
direct conversion from DER to PEM as well, so no native interactions
with the OpenSSL API are actually necessary these days.
@addaleax addaleax merged commit 9c5dba9 into main Jul 11, 2024
3 checks passed
@addaleax addaleax deleted the skip-openssl-api branch July 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants