Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven changed to Sentry SDK #51

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

scattered-development
Copy link
Contributor

@scattered-development scattered-development commented Jul 21, 2024

…/migration/raven-to-sentry-sdk/

from - Issue starting Celery in generated APP #50

2024-07-17 18:49:15 Unable to load celery application.
2024-07-17 18:49:15 'pydantic_core._pydantic_core.url' object has no attribute 'strip'

the apparent cause was from worker/tests.py starting up the worker:

raven was failing due to dependency on pydantic 1 where url inherits from string

it was confirmed that sentry was receiving messages via from sentry_sdk import capture_message which was omited for PR

info on migration from raven to sentry_sdk below

https://docs.sentry.io/platforms/python/migration/raven-to-sentry-sdk/

@scattered-development scattered-development changed the title # Raven changed to Sentry SDK https://docs.sentry.io/platforms/python… Raven changed to Sentry SDK https://docs.sentry.io/platforms/python… Jul 21, 2024
@scattered-development scattered-development changed the title Raven changed to Sentry SDK https://docs.sentry.io/platforms/python… Raven changed to Sentry SDK Jul 21, 2024
@Jibola Jibola self-requested a review July 23, 2024 14:28
@Jibola
Copy link
Collaborator

Jibola commented Aug 5, 2024

Thanks for working on this! Could you add in the sentry package to the pyproject.toml and then remove the raven package as well?

@Jibola Jibola merged commit 9dba074 into mongodb-labs:main Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants