-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PYTHON-4604 Bundle libmongocrypt 1.11.0 #876
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One clarifying question, otherwise LGTM!
} | ||
], | ||
"metadata": { | ||
"timestamp": "2024-06-28T19:11:17.100829+00:00", | ||
"timestamp": "2024-08-08T02:35:36.986098+00:00", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this always going to be hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is auto-generated by Silk
Do we need to do any work in pymongocrypt for PYTHON-4392 before we release this? |
The other way around, we need a release of pymongocrypt to support PYTHON-4392 |
Right, I get that but I'm wondering if we need to make any changes to the bindings besides upgrading to 1.11+. |
I updated the bindings, and there were only docstring changes |
@ShaneHarvey good to merge? |
No description provided.