Improved Bulk Write API #1509
Merged
Improved Bulk Write API #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5527 DRIVERS-2975 --------- Co-authored-by: Viacheslav Babanin <frest0512@gmail.com>
stIncMale
commented
Oct 3, 2024
stIncMale
commented
Nov 27, 2024
driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java
Outdated
Show resolved
Hide resolved
- Created and documented the new Reactive Bulk Write API. - Enabled unified and prose tests for reactive Bulk Write API. JAVA-5530 --------- Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
commented
Jan 2, 2025
| @@ -125,7 +125,7 @@ public final class ClusterFixture { | |||
| private static final String MONGODB_OCSP_SHOULD_SUCCEED = "org.mongodb.test.ocsp.tls.should.succeed"; | |||
| private static final String DEFAULT_DATABASE_NAME = "JavaDriverTest"; | |||
| private static final int COMMAND_NOT_FOUND_ERROR_CODE = 59; | |||
| public static final long TIMEOUT = 60L; | |||
| public static final long TIMEOUT = 120L; | |||
There was a problem hiding this comment.
Even this new value is not enough, and AbstractClientSideOperationsTimeoutProseTest.test11MultiBatchBulkWrites times out sometimes: https://parsley.mongodb.com/test/mongo_java_driver_tests_jdk_secure__version~latest_os~linux_topology~sharded_cluster_auth~auth_ssl~ssl_jdk~jdk8_test_reactive_patch_dc9c8a60046b344d96682b304553730c74e174ae_67762302c5d98d0007f85923_25_01_02_05_24_22/0/a6808dc631487d69fa56640e53c71b5e?bookmarks=0,7,9,11,133&shareLine=0.
There was a problem hiding this comment.
Investigation ticket has been created https://jira.mongodb.org/browse/JAVA-5738.
vbabanin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following test runners execute the unified and prose tests added in this PR:
com.mongodb.client.AbstractClientSideOperationsTimeoutProseTestcom.mongodb.client.unified.VersionedApiTestcom.mongodb.client.unified.UnifiedTransactionsTestcom.mongodb.client.unified.ServerSelectionLoggingTestcom.mongodb.client.unified.UnifiedRetryableWritesTestcom.mongodb.client.unified.CommandMonitoringTestcom.mongodb.client.unified.UnifiedCrudTestcom.mongodb.client.CrudProseTestJAVA-4586:
JAVA-4586_bulk-writefeature branch. However, the test for it (CommandMessageTest.getCommandDocumentFromClientBulkWrite) is in the current PR (it was introduced by Implement splitting and encodingops,nsInfoas separateOP_MSGsections, implement prose tests #1495).ops,nsInfoas separateOP_MSGsections, implement prose tests #1495)Base*interfaces to better reflect the methods shared by different client write model options #1597, MakeAbstractClientUpdateModelimplementClientWriteModel#1598, Tidy up BULK-TODOs #1599)