From 008cac10c178195afa0a7451f2faf43d472ca787 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Sat, 28 Sep 2024 22:21:35 +0800 Subject: [PATCH 1/3] Update bug-report.yml (#3022) --- .github/ISSUE_TEMPLATE/bug-report.yml | 30 ++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 1768b588f9..4a679f2d2a 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -70,13 +70,21 @@ body: label: Version of SkiaSharp description: What version of SkiaSharp are you using? options: - - 3.x (Alpha) - - 2.88.4-preview (Preview) - - 2.88.3 (Current) - - 2.88.2 (Previous) + - 3.x-preview.4 (Current Preview) + - 3.x-preview.3 (Previous Preview) + - 3.x-preview.2 (Deprecated) + - 3.x-preview.1 (Deprecated) + - 2.88.9-preview.1 (Preview) + - 2.88.8 (Current) + - 2.88.7 (Previous) + - 2.88.6 (Deprecated) + - 2.88.5 (Deprecated) + - 2.88.4 (Deprecated) + - 2.88.3 (Deprecated) + - 2.88.2 (Deprecated) - 2.88.1 (Deprecated) - 2.88.0 (Deprecated) - - 2.80.x (Deprecated) + - 2.80.x (Obsolete) - 1.x (Obsolete) - Other (Please indicate in the description) default: 2 @@ -88,10 +96,18 @@ body: label: Last Known Good Version of SkiaSharp description: What version of SkiaSharp still did what you expected? options: - - 2.88.2 (Previous) + - 3.x-preview.3 (Previous Preview) + - 3.x-preview.2 (Deprecated) + - 3.x-preview.1 (Deprecated) + - 2.88.7 (Previous) + - 2.88.6 (Deprecated) + - 2.88.5 (Deprecated) + - 2.88.4 (Deprecated) + - 2.88.3 (Deprecated) + - 2.88.2 (Deprecated) - 2.88.1 (Deprecated) - 2.88.0 (Deprecated) - - 2.80.x (Deprecated) + - 2.80.x (Obsolete) - 1.x (Obsolete) - Other (Please indicate in the description) default: 0 From 4d4e70db090fb0258d2497a374140c525cb9d1c1 Mon Sep 17 00:00:00 2001 From: Matthew Leibowitz Date: Sat, 28 Sep 2024 22:23:22 +0800 Subject: [PATCH 2/3] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 4a679f2d2a..394c66ff77 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -87,7 +87,7 @@ body: - 2.80.x (Obsolete) - 1.x (Obsolete) - Other (Please indicate in the description) - default: 2 + default: 6 - type: dropdown id: goodversion validations: @@ -110,7 +110,7 @@ body: - 2.80.x (Obsolete) - 1.x (Obsolete) - Other (Please indicate in the description) - default: 0 + default: 4 - type: dropdown id: ide validations: From 2f6bc0132afe35a1ef9da414f81f63a3ba680f33 Mon Sep 17 00:00:00 2001 From: David Sungaila Date: Wed, 23 Oct 2024 14:40:26 +0200 Subject: [PATCH 3/3] Revert SKBitmap.Encode with SKPngEncoderOptions to previous behavior (2.88.8) (#3014) * Revert SKBitmap.Encode with SKPngEncoderOptions to previous behavior * Update SKPixmap.cs --------- Co-authored-by: Matthew Leibowitz --- binding/SkiaSharp/SKPixmap.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binding/SkiaSharp/SKPixmap.cs b/binding/SkiaSharp/SKPixmap.cs index ff3875bcc6..19df483f73 100644 --- a/binding/SkiaSharp/SKPixmap.cs +++ b/binding/SkiaSharp/SKPixmap.cs @@ -237,7 +237,7 @@ public bool Encode (SKWStream dst, SKEncodedImageFormat encoder, int quality) => SKEncodedImageFormat.Jpeg => Encode (dst, new SKJpegEncoderOptions (quality)), SKEncodedImageFormat.Png => - Encode (dst, new SKPngEncoderOptions ()), + Encode (dst, SKPngEncoderOptions.Default), SKEncodedImageFormat.Webp when quality == 100 => Encode (dst, new SKWebpEncoderOptions (SKWebpEncoderCompression.Lossless, 75)), SKEncodedImageFormat.Webp =>