3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245

baywet · 2018-01-29T20:49:26Z

Hi,
We were blocked from upgrading to 3.0.9 because of this one #226
I just tried upgrading to 3.0.10 and I'm getting a lot of errors like that.

Error: Could not find source map for: "...\subcontrols\peoplepicker\configuration\index.ts"
    at CoverageTransformer.addFileCoverage (...\node_modules\remap-istanbul\lib\CoverageTransformer.js:171:18)
    at ...\node_modules\remap-istanbul\lib\CoverageTransformer.js:298:14
    at Array.forEach (native)
    at CoverageTransformer.addCoverage (...\node_modules\remap-istanbul\lib\CoverageTransformer.js:296:24)
    at ...\node_modules\remap-istanbul\lib\remap.js:51:13
    at Array.forEach (native)
    at Reporter.remap (...\node_modules\remap-istanbul\lib\remap.js:50:16)
    at ...\node_modules\karma-typescript\dist\karma\reporter.js:38:42
    at Array.forEach (native)
    at Collection.forEach (...\node_modules\karma\lib\browser_collection.js:93:21)
    at Reporter.create.onRunComplete (...\node_modules\karma-typescript\dist\karma\reporter.js:26:26)
    at Server.<anonymous> (...\node_modules\karma\lib\events.js:13:22)
    at emitTwo (events.js:111:20)
    at Server.emit (events.js:194:7)
    at emitRunCompleteIfAllBrowsersDone (...\node_modules\karma\lib\server.js:295:12)
    at Server.<anonymous> (...\node_modules\karma\lib\server.js:326:7)

[reporter.karma-typescript]: TypeError: Cannot read property 'text' of undefined

Might be relate to that #240

The text was updated successfully, but these errors were encountered:

mquireyns · 2018-01-29T23:39:30Z

I get the same error when upgrading from 3.0.8 to 3.0.10.
You should be able to reproduce it with this: https://github.com/MrMosterd/bugreport1

johnny-mh · 2018-01-30T00:41:40Z

I have same issue. covered line are mismatched.

coltonmercurio · 2018-01-30T02:06:43Z

Confirming the same issue.

erikbarke · 2018-01-30T05:30:27Z

It works if I lock down remap-istanbul to v0.8.4 😞

erikbarke · 2018-01-30T06:19:38Z

The culprit is a regex in remap-istanbul that doesn't match the inline source maps from karma-typescript: SitePen/remap-istanbul#149. I'll cut a panic release today with 'remap-istanbul@0.8.4'...

erikbarke · 2018-01-30T09:41:02Z

v3.0.11 is on npm now 😊

rolandjitsu · 2018-01-30T09:45:10Z

😄 now this is back:

30 01 2018 10:44:34.273:ERROR [karma]: TypeError: sourceMap.originalPositionFor is not a function
    at getMapping (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/getMapping.js:27:26)
    at getMappingResolved (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/CoverageTransformer.js:204:46)
    at remapBranch (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/remapBranch.js:14:19)
    at /Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/CoverageTransformer.js:214:44
    at Array.forEach (<anonymous>)
    at CoverageTransformer.addFileCoverage (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/CoverageTransformer.js:210:42)
    at /Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/CoverageTransformer.js:268:14
    at Array.forEach (<anonymous>)
    at CoverageTransformer.addCoverage (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/CoverageTransformer.js:266:24)
    at /Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/remap.js:48:13
    at Array.forEach (<anonymous>)
    at Reporter.remap (/Users/agroza/Projects/@bbpviz/utils/node_modules/remap-istanbul/lib/remap.js:47:16)
    at /Users/agroza/Projects/@bbpviz/utils/node_modules/karma-typescript/dist/karma/reporter.js:38:42
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/agroza/Projects/@bbpviz/utils/node_modules/karma/lib/browser_collection.js:93:21)
    at Reporter.create.onRunComplete (/Users/agroza/Projects/@bbpviz/utils/node_modules/karma-typescript/dist/karma/reporter.js:26:26)
npm ERR! code ELIFECYCLE

Removing all the installed packages does not help.

erikbarke · 2018-01-30T10:21:20Z

I'm working on a fix in #246, feel free to try it out!

baywet · 2018-01-30T20:10:24Z

I can confirm that 3.0.11 workarounds this final issue and allows us to be back on latest version. Thanks guys!

erikbarke · 2018-01-30T21:27:11Z

Ok, so 3.0.11 works for you @baywet, but not for you @rolandjitsu? My guess is using different versions of npm gives different results now because of the source-map dependency in remap-istanbul, as described in #240. It would be really helpful if you guys could verify that PR #246 works for both of you!

baywet · 2018-01-31T13:43:30Z

on my local machine node 7.10.0
on the build agent 8.9.1
both work with 3.0.11
all on windows
the fix you authored seems to be working properly on my machine (pulled your branch, npm i, gulp build, npm link and npm link karma-typescript in my repo, let me know if I missed something)

rolandjitsu · 2018-01-31T18:05:44Z

I'm running on OS X Sierra, node 8.4, npm 5.6. I've been using Yarn to install the packages though. Might be because of that. I've switched to jest for now, but I will try the PR out on some other projects where I still use karma.

TimothyMischief · 2018-02-01T03:46:21Z

Jumping into say I'm on 3.0.11 and getting the same error as @rolandjitsu (as below from my machine.)

I found this which seems to be tackling a similar problem and was resolved by moving to remap-istanbul@0.9.6 https://github.com/apache/metron/pull/908

I've tried using yarn resolutions to override the dependency but it's not playing nice for some reason. I'll keep trying and report back.

UPDATE: got resolutions working, forcing remap-istanbul to v0.9.6 has solved it for me.

Error on my machine (before remap-instanbul resolutions solve):

    at getMapping (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/getMapping.js:27:26)
    at getMappingResolved (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/CoverageTransformer.js:204:46)
    at remapBranch (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/remapBranch.js:14:19)
    at /Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/CoverageTransformer.js:214:44
    at Array.forEach (native)
    at CoverageTransformer.addFileCoverage (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/CoverageTransformer.js:210:42)
    at /Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/CoverageTransformer.js:268:14
    at Array.forEach (native)
    at CoverageTransformer.addCoverage (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/CoverageTransformer.js:266:24)
    at /Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/remap.js:48:13
    at Array.forEach (native)
    at Reporter.remap (/Users/tim/Dev/Holdings/node_modules/remap-istanbul/lib/remap.js:47:16)
    at /Users/tim/Dev/Holdings/node_modules/karma-typescript/dist/karma/reporter.js:38:42
    at Array.forEach (native)
    at Collection.forEach (/Users/tim/Dev/Holdings/node_modules/karma/lib/browser_collection.js:93:21)
    at Reporter.create.onRunComplete (/Users/tim/Dev/Holdings/node_modules/karma-typescript/dist/karma/reporter.js:26:26)```

erikbarke · 2018-02-01T04:58:28Z

@TimothyDespair, the PR #246 uses remap-istanbul@0.10.1, does that branch work for you if you install it like baywet describes earlier in this thread?

TimothyMischief · 2018-02-01T08:33:55Z

@erikbarke Just gave it a shot. Seems to be working!

erikbarke · 2018-02-01T08:46:06Z

Awsesome guys, thanks!!

erikbarke added the bug label Jan 30, 2018

erikbarke pushed a commit that referenced this issue Jan 30, 2018

Lock remap-istanbul to v0.8.4, #245

7cd49b3

erikbarke pushed a commit that referenced this issue Jan 30, 2018

Move the source map comment to the last line, #245

403bfa4

erikbarke mentioned this issue Jan 30, 2018

source-map dependency >=0.5.6 --> 0.7.0 breaks #240

Closed

erikbarke closed this as completed Feb 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245

3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245

baywet commented Jan 29, 2018

mquireyns commented Jan 29, 2018 •

edited

Loading

johnny-mh commented Jan 30, 2018

coltonmercurio commented Jan 30, 2018 •

edited

Loading

erikbarke commented Jan 30, 2018

erikbarke commented Jan 30, 2018

erikbarke commented Jan 30, 2018

rolandjitsu commented Jan 30, 2018 •

edited

Loading

erikbarke commented Jan 30, 2018

baywet commented Jan 30, 2018

erikbarke commented Jan 30, 2018

baywet commented Jan 31, 2018 •

edited

Loading

rolandjitsu commented Jan 31, 2018

TimothyMischief commented Feb 1, 2018 •

edited

Loading

erikbarke commented Feb 1, 2018

TimothyMischief commented Feb 1, 2018

erikbarke commented Feb 1, 2018

3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245

3.0.8 => 3.0.10 Error: Could not find source map for: "...\validationHelper.ts" #245

Comments

baywet commented Jan 29, 2018

mquireyns commented Jan 29, 2018 • edited Loading

johnny-mh commented Jan 30, 2018

coltonmercurio commented Jan 30, 2018 • edited Loading

erikbarke commented Jan 30, 2018

erikbarke commented Jan 30, 2018

erikbarke commented Jan 30, 2018

rolandjitsu commented Jan 30, 2018 • edited Loading

erikbarke commented Jan 30, 2018

baywet commented Jan 30, 2018

erikbarke commented Jan 30, 2018

baywet commented Jan 31, 2018 • edited Loading

rolandjitsu commented Jan 31, 2018

TimothyMischief commented Feb 1, 2018 • edited Loading

erikbarke commented Feb 1, 2018

TimothyMischief commented Feb 1, 2018

erikbarke commented Feb 1, 2018

mquireyns commented Jan 29, 2018 •

edited

Loading

coltonmercurio commented Jan 30, 2018 •

edited

Loading

rolandjitsu commented Jan 30, 2018 •

edited

Loading

baywet commented Jan 31, 2018 •

edited

Loading

TimothyMischief commented Feb 1, 2018 •

edited

Loading