Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of native constructors with utility functions #197

Open
ioncreature opened this issue Feb 28, 2018 · 2 comments
Open

Extension of native constructors with utility functions #197

ioncreature opened this issue Feb 28, 2018 · 2 comments

Comments

@ioncreature
Copy link

ioncreature commented Feb 28, 2018

Hello!

I like the library. But.

But I do not want this library to add anything to Object, Function or any other native entity.

This approach could conflict with developer if developer wants to extend base entities in own project
It could conflict with other libraries like SugarJS
It could conflict with future versions of JS

Please, use your utility functions locally(and import it when it needed) and do not make it global

@hthetiot
Copy link
Contributor

hthetiot commented Mar 9, 2018

@ioncreature Check v2 branch.

We are aware of the issue with current version.
We don't have the bandwidth to fix v1 for now, any PR welcome.

@codebling
Copy link

codebling commented Apr 15, 2019

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. As mentioned, branch v2 fixes these issues by avoiding global object modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants