Benchmark slashes queue processing #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 824 KB (no changes) ✅ dancelight runtime: 2148 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
nanocryk
force-pushed
the
jeremy-bench-slashes
branch
from
3396ba9 to
87103ab
Compare
Agusrodri
added a commit
that referenced
this pull request
Jan 20, 2025
* first approach * start adding on_era_end to ExternalValidatorSlashes * add timestamp for era * send slashes once they are confirmed * apply slashes next era * first test sending messages * modify more tests * more tests * more tests for jeremy * fix tests * Simplify slashes queue processing (#800) * simplify slash process queue and process a page every block * on process page in on_initialize * fix one test * first integrationt test working * more tests * slashes * test we are sending message to eth * new integration test * slashes are accumulated across eras * cleanup some tests * zepter * lint * fmt * Benchmark slashes queue processing (#801) * optimize storage writes and prepare bench * run bench locally * fmt * ts-api * toml-maid * fix clippy * add test for account_id encoding * add SlashesMessageSent event and tests * fmt * api-augment * use FixedBytes token for the slash account * pr comments * mock optimization * add test for invulnerables grandpa slashing * fix docs * api-augment --------- Co-authored-by: girazoki <gorka.irazoki@gmail.com> Co-authored-by: nanocryk <6422796+nanocryk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the function signature of
process_slashes_queueto take the limit as argument, which helps benchmarking it. It also now returns the number of slashes processed to return the actually used weight.Following suggestion in #793, I only read and write from storage once by moving the
forloop inside themutatecall.