Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move network package into iso8583-connection module #276

Open
alovak opened this issue Sep 7, 2023 · 2 comments
Open

Move network package into iso8583-connection module #276

alovak opened this issue Sep 7, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@alovak
Copy link
Contributor

alovak commented Sep 7, 2023

After the creation of the https://github.com/moov-io/iso8583-connection module, it should be the new home for the network package.

I am considering removing it from the iso8583 module in two steps:

  1. Copy it to the https://github.com/moov-io/iso8583-connection module and deprecate it in the iso8583 module.
  2. Remove it from the iso8583 module.
@alovak alovak added the help wanted Extra attention is needed label Sep 7, 2023
@adamdecaf
Copy link
Member

You could always forward the old types to newer ones when you mark them as deprecated. Then callers won't need to immediately change unless they're checking for Deprecated calls.

Example: https://github.com/golang/go/blob/master/src/io/ioutil/ioutil.go

@GalihFajar
Copy link
Contributor

GalihFajar commented Oct 12, 2023

Hi, is this issue still available to work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants