check for the max length in BerTLV prefix #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spec I'm working with now, there is a max length for BerTLV fields.
Currently, we are ignoring the
Length
(max length) of the field spec forprefix.BerTLV
. This PR changes the prefix a little bit:Length
is set to0
or is not set (0
is zero value used for theLength
anyway) - we do not check max length - this is to support current integrations which, most probably, follow the example from our tests like this:Length
is set to non-zero value, perform the checkThis PR is a breaking change (potentially) if you use the
prefix.BerTLV
and set non-zeroLength
in the field spec.