Expose subtitle file size #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyzical
commented
Sep 23, 2023
phyzical
commented
Sep 25, 2023
phyzical
commented
Sep 25, 2023
|
@morpheus65535 reverted the api change, i will see if i can make the required around a version lax application side 👍 |
|
@morpheus65535 anything still blocking this? |
Still one comment left |
morpheus65535
requested changes
Oct 10, 2023
Add a safer check, default to 0 size
phyzical
commented
Oct 10, 2023
morpheus65535
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds an alias for the api under /v1