-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log filter level check. #2663
Conversation
As per #2593 (comment), it seems logging paths are potentially not hit in automated tests. There does seem to be a workflow that starts the application but that did not catch my commit/push mistake. |
e27fcbd
to
bebc2ff
Compare
Yea doesn't look like those get executed. It should've had a fail on the import for the class, which it did not... |
bebc2ff
to
479df80
Compare
@Omar007 Still something wrong here? Using Python 3.8.
|
Same thing with 3.11:
|
It should've been fine based on the docs and test file but I guess there's still something else (which also means the test file is setting up the record incorrectly? 😕 ). EDIT: dove a bit further into Python and looks like the LogRecord constructor splits the level argument into separate fields unlike the args supplied to the |
Correct errors in the logging changes in #2593.