From e669c1c578a89a1b2468d7c710ad4ee4cf8731fc Mon Sep 17 00:00:00 2001 From: Omar Pakker Date: Mon, 16 Sep 2024 11:07:34 +0200 Subject: [PATCH 1/2] Fix log filter level check. --- bazarr/app/logger.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bazarr/app/logger.py b/bazarr/app/logger.py index 8803ad3cb..e5f2fce7d 100644 --- a/bazarr/app/logger.py +++ b/bazarr/app/logger.py @@ -62,7 +62,7 @@ def filter(self, record): # no filtering in debug mode or if originating from us return True - if record.level != loggin.ERROR: + if record.level < logging.ERROR: return False unwantedMessages = [ From 479df80357da1459f748752885676b47052c11da Mon Sep 17 00:00:00 2001 From: Omar Pakker Date: Mon, 16 Sep 2024 11:56:27 +0200 Subject: [PATCH 2/2] Add tests for waitress log filter. --- tests/test_logging_filters.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 tests/test_logging_filters.py diff --git a/tests/test_logging_filters.py b/tests/test_logging_filters.py new file mode 100644 index 000000000..9209fb09e --- /dev/null +++ b/tests/test_logging_filters.py @@ -0,0 +1,22 @@ +import logging + +from bazarr.app.logger import UnwantedWaitressMessageFilter + +def test_true_for_bazarr(): + record = logging.makeLogRecord({ + "level": logging.INFO, + "msg": "a message from BAZARR for logging" + }) + assert UnwantedWaitressMessageFilter().filter(record) + +def test_false_below_error(): + record = logging.makeLogRecord({ + "level": logging.INFO + }) + assert not UnwantedWaitressMessageFilter().filter(record) + +def test_true_error_up(): + record = logging.makeLogRecord({ + "level": logging.CRITICAL + }) + assert UnwantedWaitressMessageFilter().filter(record)