Test Aave v3.3 #898
Draft
Test Aave v3.3 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
commented
Dec 20, 2024
| @@ -8,7 +8,7 @@ config/=config/ | |||
| @morpho-utils/=lib/morpho-utils/src/ | |||
| @morpho-data-structures/=lib/morpho-data-structures/src/ | |||
|
|
|||
| @openzeppelin/=lib/morpho-utils/lib/openzeppelin-contracts/ | |||
| @openzeppelin/contracts/=lib/morpho-utils/lib/openzeppelin-contracts/contracts/ | |||
There was a problem hiding this comment.
To fix an issue where the remapping used is captured to be the one in the new aave-v3-origin submodule
| @@ -21,7 +21,7 @@ import {Errors as AaveErrors} from "@aave-v3-core/protocol/libraries/helpers/Err | |||
| import {ReserveConfiguration} from "@aave-v3-core/protocol/libraries/configuration/ReserveConfiguration.sol"; | |||
|
|
|||
| import {PermitHash} from "@permit2/libraries/PermitHash.sol"; | |||
| import {IAllowanceTransfer, AllowanceTransfer} from "@permit2/AllowanceTransfer.sol"; | |||
| import {IAllowanceTransfer} from "@permit2/AllowanceTransfer.sol"; | |||
There was a problem hiding this comment.
Needed to avoid having to compile with 0.8.17 exactly, as the version is fixed in AllowanceTransfer (but not in IAllowanceTransfer)
Comment on lines
+39
to
+41
| interface IAllowanceTransferExtended is IAllowanceTransfer { | ||
| function DOMAIN_SEPARATOR() external view returns (bytes32); | ||
| } |
There was a problem hiding this comment.
Needed because DOMAIN_SEPARATOR is used by the tests, on top of functions in IAllowanceTransfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not meant to be merged, as it's only useful before the v3.3 update. After the update, the new code will automatically be tested.
Limitation: for now it is testing by compiling everything with the same version, but ma3 is compiled with 0.8.17 and aave-v3.3 is compiled with >=0.8.20