Base Bundler #430
Merged
Base Bundler #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathisGD
requested review from
adhusson,
Rubilmax,
QGarchery,
MerlinEgalite and
Jean-Grimal
Rubilmax
reviewed
May 7, 2024
Rubilmax
reviewed
May 7, 2024
adhusson
reviewed
May 7, 2024
adhusson
previously approved these changes
May 7, 2024
Rubilmax
previously approved these changes
May 7, 2024
QGarchery
reviewed
May 7, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Rubilmax
previously approved these changes
May 14, 2024
Jean-Grimal
reviewed
May 14, 2024
QGarchery
reviewed
May 14, 2024
Co-authored-by: Quentin Garchery <QGarchery@users.noreply.github.com> Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Jean-Grimal
reviewed
May 14, 2024
adhusson
previously approved these changes
May 14, 2024
There was a problem hiding this comment.
I don't think it's a blocker but if I run tests with --chain other than 1, I get several repetitions of
proptest: Aborting shrinking after the PROPTEST_MAX_SHRINK_ITERS environment variable or ProptestConfig.max_shrink_iters iterations (set 64 to a large(r) value to shrink more; current configuration: 64 iterations)
MerlinEgalite
previously approved these changes
May 14, 2024
Jean-Grimal
previously approved these changes
May 14, 2024
MathisGD
dismissed stale reviews from Jean-Grimal, MerlinEgalite, and adhusson
via
4b42813
MathisGD
requested review from
adhusson,
Rubilmax,
Jean-Grimal,
MerlinEgalite and
QGarchery
QGarchery
approved these changes
May 15, 2024
MerlinEgalite
approved these changes
May 15, 2024
adhusson
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base Bundler !
Test and config archi could be refactored (and simplified imo, see #428).
It would be great to have a skip cheatcode at the
setUpstage to be able to skip tests that are not needed on base.