Post cantina #106
Merged
Post cantina #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(ifc): move natspecs to interfaces
feat(ifc): add adaptive curve irm interface
MerlinEgalite
requested review from
a team,
Rubilmax,
Jean-Grimal,
QGarchery,
peyha and
MathisGD
and removed request for
a team
Make params constant
…me-math-operations
Docs/interface
This comment was marked as resolved.
This comment was marked as resolved.
StErMi
reviewed
Dec 20, 2023
Merged
(nitpick) `to0` => `toZero`
Rubilmax
previously approved these changes
Dec 20, 2023
Rubilmax
previously approved these changes
Dec 20, 2023
(nitpick) mathlib style
|
Looks good |
Rubilmax
previously approved these changes
Dec 21, 2023
docs(constants): re-add missing natspec
StErMi
approved these changes
Dec 21, 2023
MathisGD
previously approved these changes
Dec 22, 2023
Update Morpho Blue
MathisGD
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
feat(ifc): add adaptive curve irm interface #100
AdaptiveCurveIrmMake params constant #103
Rename math operations #107
MathLib.wMulDown&MathLib.wDivDownregarding their round-to-zero behavior in the integer space (#127)docs(irm): speed is not constant #108
fix(constants): lower max rate at target #105
(nitpick) nitpick #116
(nitpick)
to0=>toZero#114To0ToZerodocs(constants): re-add missing natspec #117