-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pkg_resources
with importlib
and add python 3.13 to test suite.
#574
base: main
Are you sure you want to change the base?
Conversation
It looks like the entry points methods in python 3.9 is different from python >= 3.10. So, that means we can't support both 3.9 and 3.13 whenever it's released. We can table these changes until we're ready to move on to python >= 3.10. |
pkg_resources
with importlib
; use lark
in .yml files instead of lark-parser
pkg_resources
with importlib
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 61.88% 62.02% +0.14%
==========================================
Files 16 16
Lines 1658 1667 +9
==========================================
+ Hits 1026 1034 +8
- Misses 632 633 +1 |
I don't think it's necessarily the right call here, but we could opt for using |
I say we just wait. Maybe at the next dev meeting we can start talking about the plan to drop 3.9 and add 3.13, which will be officially released next month I believe. |
pkg_resources
with importlib
pkg_resources
with importlib
and add python 3.13 to test suite.
PR Summary:
I'm trying to fix some of the deprecation errors we're getting in the mosdef packages. One of them is coming from foyer with the use of
pkg_resources
.pkg_resources will be removed in python 3.13
Note: This PR is not compatible with python 3.9, so we can't merge it until we want to drop 3.9 support and add 3.13.
PR Checklist