Skip to content

Commit

Permalink
fix: no video data in video files (#125)
Browse files Browse the repository at this point in the history
  • Loading branch information
moshfeu authored Apr 3, 2023
1 parent 06e348a commit 7d009f4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "y2mp3",
"appname": "y2mp3",
"productName": "y2mp3",
"version": "2.5.7",
"version": "2.5.8",
"main": "main.js",
"author": {
"name": "MosheF",
Expand Down
3 changes: 2 additions & 1 deletion src/services/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const downloader = new YoutubeMp3Downloader({
ffmpegPath: ffmpegPath(), // Where is the FFmpeg binary located?
outputPath: settingsManager.downloadsFolder, // Where should the downloaded and encoded files be stored?
youtubeVideoQuality: settingsManager.audioQuality, // What video quality should be used?
filter: 'audio',
filter: 'audioandvideo',
format: settingsManager.downloadFormat,
progressTimeout: 1000,
});
Expand Down Expand Up @@ -203,6 +203,7 @@ const downloadReducer = (action: StateChangeAction) => {
} = action;
finishVideoOnError(error, videoId);
if (isCustomError(error)) {
console.log(error);
showCustomError(error.message);
break;
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/services/youtube-mp3-downloader/queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class Queue<T> {
try {
await this.currentTask.main(this.currentTask);
} catch (error) {
console.info('task failed:', this.currentTask);
console.info('task failed:', this.currentTask, error);
this.remove(this.currentTask.id);
} finally {
this.process();
Expand Down

0 comments on commit 7d009f4

Please sign in to comment.