Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support expose envoy metrics for plugins #820

Open
wonderflow opened this issue Dec 11, 2024 · 2 comments · May be fixed by #827
Open

Support expose envoy metrics for plugins #820

wonderflow opened this issue Dec 11, 2024 · 2 comments · May be fixed by #827
Labels
stale

Comments

@wonderflow
Copy link
Contributor

wonderflow commented Dec 11, 2024 •
edited
Loading

Description

Envoy has metrics for filters to get an overview of the plugin execution statistics, we need to expose metrics for plugins.

Use Scenes

Just like the envoy filters, e.g. the global rate-limiting has metric statistics to describe how many requests has over the limitation. It can also help us for troubleshooting.

Advice

thanks to @spacewander for the suggestions below:
Envoy Go metric API: https://github.com/envoyproxy/envoy/blob/0ff8fc30ae72a5a0efdc7d651f217021c77056b3/contrib/golang/common/go/api/filter.go#L312
While htnn not inetgrated yet, we need to enhance this part:

htnn/api/pkg/filtermanager/config.go

Line 167 in 2e9de01

fc.InitFailure = initer.Init(nil)

@spacewander
Copy link
Member

More precisely, it is

htnn/api/pkg/filtermanager/config.go

Line 179 in bde6f6f

func (p *FilterManagerConfigParser) Parse(any *anypb.Any, callbacks capi.ConfigCallbackHandler) (interface{}, error) {

@wonderflow wonderflow linked a pull request Dec 18, 2024 that will close this issue
Open
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged with no stale labels or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metrics: support expose metrics for plugins wonderflow/htnn
2 participants
@wonderflow @spacewander