Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentinel plugin #740

Merged
merged 20 commits into from
Oct 21, 2024
Merged

feat: sentinel plugin #740

merged 20 commits into from
Oct 21, 2024

Conversation

WeixinX
Copy link
Contributor

@WeixinX WeixinX commented Sep 23, 2024

Related to #725

Sentinel plugin and its unit tests, integration tests

The relevant documents will be coming soon

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 79.64602% with 69 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (715dd41) to head (59e9a4c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
types/plugins/sentinel/config.go 74.69% 14 Missing and 7 partials ⚠️
plugins/plugins/sentinel/config.go 71.69% 10 Missing and 5 partials ⚠️
plugins/plugins/sentinel/filter.go 89.88% 6 Missing and 3 partials ⚠️
plugins/plugins/sentinel/rules/circuitbreaker.go 81.39% 5 Missing and 3 partials ⚠️
plugins/plugins/sentinel/rules/flow.go 75.75% 5 Missing and 3 partials ⚠️
plugins/plugins/sentinel/rules/hotspot.go 78.94% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   87.70%   87.37%   -0.34%     
==========================================
  Files         136      142       +6     
  Lines        8157     8512     +355     
==========================================
+ Hits         7154     7437     +283     
- Misses        782      829      +47     
- Partials      221      246      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacewander
Copy link
Member

spacewander commented Sep 24, 2024

Let's merge main to make CI pass.

Copy link

👋 Hi, I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@github-actions github-actions bot removed the conflict label Sep 24, 2024
@WeixinX
Copy link
Contributor Author

WeixinX commented Sep 24, 2024

When I was running CI earlier, I found an error that seemed to have nothing to do with the code I committed, but rather with nacos. See controller-test - Test.

@spacewander
Copy link
Member

When I was running CI earlier, I found an error that seemed to have nothing to do with the code I committed, but rather with nacos. See controller-test - Test.

The integration test of controller is not stable, it may fail once in a dozen times. Feel free to ignore it if you think it's not caused by your code. We will rerun it if needed.

plugins/plugins/sentinel/config.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/config.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Show resolved Hide resolved
plugins/plugins/sentinel/rules/circuitbreaker.go Outdated Show resolved Hide resolved
site/content/en/docs/reference/plugins/sentinel.md Outdated Show resolved Hide resolved
Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge main to apply latest change

site/content/en/docs/reference/plugins/sentinel.md Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/config.go Show resolved Hide resolved
site/content/en/docs/reference/plugins/sentinel.md Outdated Show resolved Hide resolved
site/content/en/docs/reference/plugins/sentinel.md Outdated Show resolved Hide resolved
site/content/en/docs/reference/plugins/sentinel.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 9, 2024

👋 Hi, I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

Copy link
Member

@alpha-baby alpha-baby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

👋 Hi, I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

maintainer/feature_maturity_level.yaml Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Outdated Show resolved Hide resolved
plugins/plugins/sentinel/filter.go Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the conflict label Oct 21, 2024
Copy link

👋 Hi, I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

plugins/plugins/sentinel/config_test.go Outdated Show resolved Hide resolved
@spacewander spacewander merged commit 8f81a79 into mosn:main Oct 21, 2024
16 checks passed
@spacewander
Copy link
Member

@WeixinX
Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants