-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sentinel plugin #740
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
- Coverage 87.70% 87.37% -0.34%
==========================================
Files 136 142 +6
Lines 8157 8512 +355
==========================================
+ Hits 7154 7437 +283
- Misses 782 829 +47
- Partials 221 246 +25 ☔ View full report in Codecov by Sentry. |
Let's merge main to make CI pass. |
👋 Hi, I detected conflicts against the base branch 🙊 |
When I was running CI earlier, I found an error that seemed to have nothing to do with the code I committed, but rather with nacos. See controller-test - Test. |
The integration test of controller is not stable, it may fail once in a dozen times. Feel free to ignore it if you think it's not caused by your code. We will rerun it if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge main to apply latest change
👋 Hi, I detected conflicts against the base branch 🙊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👋 Hi, I detected conflicts against the base branch 🙊 |
👋 Hi, I detected conflicts against the base branch 🙊 |
@WeixinX |
Related to #725
Sentinel plugin and its unit tests, integration tests
The relevant documents will be coming soon