change: allow missing consumer #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
==========================================
+ Coverage 87.70% 87.80% +0.10%
==========================================
Files 136 136
Lines 8163 8159 -4
==========================================
+ Hits 7159 7164 +5
+ Misses 783 776 -7
+ Partials 221 219 -2 ☔ View full report in Codecov by Sentry. |
If consumer is required, use consumerRestriction plugin to restrict. This change makes it possible to support limit rate per consumer coexists with limit rate without consumer. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
force-pushed
the
consumer_can_pass
branch
from
f090586
to
a511397
Compare
If consumer is required, use consumerRestriction plugin to restrict. This change makes it possible to support limit rate per consumer coexists with limit rate without consumer. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If consumer is required, use consumerRestriction plugin to restrict.
This change makes it possible to support limit rate per consumer coexists with limit rate without consumer.
Signed-off-by: spacewander spacewanderlzx@gmail.com