fix: change inner req hdr caused race #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
github-actions
bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 88.49% 88.05% -0.44%
==========================================
Files 136 136
Lines 6677 8157 +1480
==========================================
+ Hits 5909 7183 +1274
- Misses 549 756 +207
+ Partials 219 218 -1 ☔ View full report in Codecov by Sentry. |
spacewander
added a commit
that referenced
this pull request
Oct 24, 2024
#775 doesn't really fix the problem. Since we already create the wrapper, we should pass the wrapper directly to OnLog, instead of setting the reqHdr field. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander
added a commit
that referenced
this pull request
Oct 28, 2024
#775 doesn't really fix the problem. Since we already create the wrapper, we should pass the wrapper directly to OnLog, instead of setting the reqHdr field. Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.