Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using sobek instead of goja #297

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

We are moving to a fork of goja under grafana org called sobek.

More info in:

We are moving to a fork of goja under grafana org called sobek.

More info in:
- grafana/k6#3772
- grafana/k6#3773
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Owner

@mostafa mostafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstoykov LGTM!

Should I release a new version?

@mstoykov
Copy link
Contributor Author

@mostafa probably a good idea. You might want to wait for v0.52.0 to be officially released in few weeks. But if you are okay with releasing then as well it is better to release now.

@mostafa mostafa merged commit 3ea6bfe into mostafa:main Jun 10, 2024
3 checks passed
@mstoykov mstoykov deleted the useSobek branch June 10, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants