Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make download_items responsive #312

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Guocork
Copy link
Collaborator

@Guocork Guocork commented Nov 18, 2024

Now, the layout in download_items is responsive.
截图 2024-11-18 16-14-41

Comment on lines -200 to +216
<Information> {}
<Progress> {}
<Actions> {}
<View> {
width: Fill,
height: Fit,
<Information> {}
}

<View> {
width: Fill,
height: Fit,
<Progress> {}
}

<View> {
width: Fill,
height: Fit,
<Actions> {}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this works we can clean up a bit:
It seems that you can actually achieve this by simply changing the width and height property on those elements directly, instead of wrapping them in views.

You can keep:

<Information> {}
<Progress> {}
<Actions> {}

And update those values directly on each element:

Actions = <View> {
 width: Fill, height: Fit
// ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants