This repository has been archived by the owner on Feb 7, 2019. It is now read-only.
Styling adjustments to align entry detail buttons during edit and view mode change #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
devinreams
reviewed
Mar 5, 2018
There was a problem hiding this comment.
The vertical padding and password "dots" are changed to match the designs:
The changes look fine by me but will want to see what @jimporter thinks.
jimporter
suggested changes
Mar 5, 2018
There was a problem hiding this comment.
Unfortunately, this doesn't actually bring us any closer to the correct visuals for the password <FieldText/>. While it looks ok on macOS now, it looks wrong on Linux (the current code in master is designed to look right on Linux since, well, that's what I use).
I'd be willing to accept something like this as a temporary workaround if it worked on Windows (where the majority of our userbase will be), but I'd prefer something that works right everywhere. I don't have a Windows dev machine though, so we'll need to find someone with one.
In the end, I'm not sure how Firefox renders the password dots in an <input> element, so that makes it pretty hard to get this right in all cases.
|
I can confirm that this works in Win10 on Firefox Nightly. |
Does this mean "the dots when you're viewing a password and when you're editing a password are identical"? That's the main issue I expect to see on Windows. Screenshots would be nice for confirmation. :) |
|
@jimporter good point, no. The size of the dots change. I was trying to put together a screencast, took me a bit.
|
|
The "obfuscated" password dots are inconsistent switching from view/edit mode and changing this one makes it consistent on Mac but even more inconsistent on Windows and Linux. We should undo this change here and see about coming back to this at #615 since we've agreed we'll prefer/prioritize the ~95% on Win. @nickbrandt do you mind pulling that dot change out? just discussed it with @jimporter and @changecourse. The remainder of this fix ("bottom buttons would jump a bit from edit to view state") should be good, though. 🙃 |
|
@devinreams @jimporter password dots reverted. Should be good to go! |
devinreams
changed the title
|
Here's the behavior on win10, Firefox nightly.
|
jimporter
suggested changes
Mar 6, 2018
| } | ||
|
|
||
| .password { | ||
| font-weight: normal; |
There was a problem hiding this comment.
I think this is unnecessary now (at least on Linux); if it's actually required to make things look ok on Windows though, then I'm fine with keeping it.
|
OK this PR looks bigger than it is becuase it was based on a branch that is now merged. Looking at the "Files changed" view shows this is just changing the height of notes so the buttons beneath don't move around too much. @jimporter @m8ttyB would you like to take one final look at this small change before we merge (by) tomorrow? |
|
@devinreams I'm 99% likely to r+ this; then I'll rebase and merge. Hopefully within the hour. |
m8ttyB
previously approved these changes
Mar 6, 2018
There was a problem hiding this comment.
r=pi, if @jimporter has anything that concerns him. I'll retest with those concerns in mind.
-Modified password read only char code to match design -Fixed issue where bottom buttons would jump a bit from edit to view state
jimporter
force-pushed
the
480-entry-details-styling
branch
from
6076b12 to
41c2f78
Compare
jimporter
approved these changes
Mar 6, 2018
|
@jimporter thanks for cleaning up (and ultimately merging) this branch 😍 |
devinreams
added a commit
that referenced
this pull request
Mar 8, 2018
* Remove link to empty API guide Fixes #366 Depends on #51 * Remove redundant link the COC is linked from the Contributing page which is a better landing page overall. keep it simple. * Disable the filter when there are no items; resolves #324 * Add disabled state for buttons and disable the "add item" button when editing a new item This also fixes some CSS with the "active" state of the button widget * Refactor our telemetry to use Redux middleware * Add missing telemetry events (and send the item id across) * Create a Redux action for sending feedback * Add a Redux action for copying fields * Rename the object for various telemetry events * Add telemetry to the doorhanger * Be extra careful about the possibility of telemetry failing * Firefox Accounts Integration (#362) * Add instruction on how to run Tox recreate (#396) * Add note on how to recreate tox dependencies * Rewrap all the lines to 80 * Prepare 0.1.4-alpha and release notes (#393) * Bump version to 0.1.4-alpha * Quick draft and placeholder release notes * Update release-notes.md * Add "FxA can eat your logins" warnings * Update release-notes.md * typos * Documentation updates from product team (#386) * add FAQs placeholder page * update homepage and styles to be HTML because it was faster than trying to make custom theme stuff happen * update navigation to be simpler * change extension to match language * finish converting index to html * add draft FAQ copy * typo and inconsistent use of Add-ons vs Extensions in menu * back to markdown with admonitions * fix styles to match new markup * move the project note to the bottom of the page * remove exclamation icons in headers * updated tour and intro based on current FxA functionality * copy edits from legal and content teams * Disable the filter when there are no items; resolves #324 * Add disabled state for buttons and disable the "add item" button when editing a new item This also fixes some CSS with the "active" state of the button widget * Refactor our telemetry to use Redux middleware * Add missing telemetry events (and send the item id across) * Create a Redux action for sending feedback * Add a Redux action for copying fields * Rename the object for various telemetry events * Add telemetry to the doorhanger * Be extra careful about the possibility of telemetry failing * Firefox Accounts Integration (#362) * add the tour screen shots * address @mheubusch comments as best can be done * Incorporate more Photon-inspired UX and UI improvements (#351) * Fix text color of wrapped inputs; resolves #264 * Change background color of primary content area when viewing or creating an entry And change color of selected item in scroll list to match so it looks like one continuous tab/element * Removal of horizontal divider in Create a New Entry & View Entry Details and change Delete button to be a button * Add arrow indicator, hide when item selected * Match title and subtitle font sizes and weights * Adjust sidebar width * Remove item count from toolbar * Update Navigation to match comps - navigation links to match Photon - larger with puffy sizes - no side vs main toolbar * fix font-weight typos from bad partial commit * Add link theme and external link icon * Small copy changes recently noticed * Center text on modal * Remove sidebar border Need a clever way to add it back and "punch through" selected items, though * Normal button for home * re-order origin and title fields so address is first * remove notes placeholder * better spacing for empty sidebar text * sidebar item typography and colors to match * make the indicator arrow more style than semantic and use the proper icon * add semantic navigation arrow image to replace left arrow tag * rename new, edit, delete, button and confirmation strings * hide right border on selected list item so its like a tab into the panel * improved modal styles * consistent bytton styles and sizes * improved item detail input and title styles * remove fancy counter from homepage * quick tweaks to doorhanger styles * re-order title and address to match d6ea846 * actually finish the re-ordering of title and address from 0c0884a * updated description to match comps * update sidebar background colors to match comps * merge FxA changes into homepage * remove pre-Alpha homepage greeting * lower-case 'e' for entry now * use product-title placeholder and undo accidental CSS specificity breakage * remove superfulous brackets * remove superfulous height and border, set proper color on item details * remove unused localized toolbar string * Merge and fix some conflicts against FxA * remove unused Homepage prop removed at 536d7e4 * sane sidebar min with grid shift to achieve wider-ness * move homepage and FxA blurb styles around and match comps * improve text and button hierarchy and clarity on modal dialogs * localize the backwards navigation arrow on popup * update item and scroll list colors to match Photon greys * "provide feedback" link for user clarity submit feedback happens after feedback is drafted * explicitly disable browser style, prevents warning messages * quick attempt fix vertical alignment of arrow indicator * fix integration tests for login, add entry, delete, and doorhanger * set a normal min-width to achieve fairly consistent size buttons so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space * change the "go back" button to micro to fit the space better * update ID locator in login.py tests * add external link widget (#397) * add external link widget * address code review comments * address children property feedback * integration test: find the correct sign in link * put things back where they were and address @jimporter review comments * Updated integration tests * Fix failing integration tests. * Fix flake8 * Fix text color of wrapped inputs; resolves #264 * Change background color of primary content area when viewing or creating an entry And change color of selected item in scroll list to match so it looks like one continuous tab/element * Removal of horizontal divider in Create a New Entry & View Entry Details and change Delete button to be a button * Add arrow indicator, hide when item selected * Match title and subtitle font sizes and weights * Adjust sidebar width * Remove item count from toolbar * Update Navigation to match comps - navigation links to match Photon - larger with puffy sizes - no side vs main toolbar * fix font-weight typos from bad partial commit * Add link theme and external link icon * Small copy changes recently noticed * Center text on modal * Remove sidebar border Need a clever way to add it back and "punch through" selected items, though * Normal button for home * re-order origin and title fields so address is first * remove notes placeholder * better spacing for empty sidebar text * sidebar item typography and colors to match * make the indicator arrow more style than semantic and use the proper icon * add semantic navigation arrow image to replace left arrow tag * rename new, edit, delete, button and confirmation strings * hide right border on selected list item so its like a tab into the panel * improved modal styles * consistent bytton styles and sizes * improved item detail input and title styles * remove fancy counter from homepage * quick tweaks to doorhanger styles * re-order title and address to match d6ea846 * updated description to match comps * actually finish the re-ordering of title and address from 0c0884a * update sidebar background colors to match comps * merge FxA changes into homepage * remove pre-Alpha homepage greeting * lower-case 'e' for entry now * use product-title placeholder and undo accidental CSS specificity breakage * remove superfulous brackets * remove superfulous height and border, set proper color on item details * remove unused localized toolbar string * Merge and fix some conflicts against FxA * remove unused Homepage prop removed at 536d7e4 * sane sidebar min with grid shift to achieve wider-ness * move homepage and FxA blurb styles around and match comps * improve text and button hierarchy and clarity on modal dialogs * localize the backwards navigation arrow on popup * update item and scroll list colors to match Photon greys * "provide feedback" link for user clarity submit feedback happens after feedback is drafted * explicitly disable browser style, prevents warning messages * quick attempt fix vertical alignment of arrow indicator * fix integration tests for login, add entry, delete, and doorhanger * set a normal min-width to achieve fairly consistent size buttons so short words like "Save" and "Edit" fill a minimum amount of space that has a good hit-area, but "Delete Entry" expands to fill space * change the "go back" button to micro to fit the space better * update ID locator in login.py tests * add external link widget (#397) * add external link widget * address code review comments * address children property feedback * integration test: find the correct sign in link * put things back where they were and address @jimporter review comments * Updated integration tests * Fix failing integration tests. * Fix flake8 * Fix homepage wait to load * Fix flake8 * Fix homepage wait to load * slow the browser down because these tests are failing very occasionally * make sure the FxA linked typography matches signed out guest mode * bump toolbar and first run actions link sizes up to match nearby button sizes * localization introduced at 9db70b2 is not actually working this way returning [object Object] instead of string * put back input sizes so there's no visibile jump going from edit to view undo some of my changes at 234d001 so things line up properly * better wrapping accounting for width of "Lockbox" * also set account-summary span to 15px for now for nav size consistency * sentence case our tagline * minr Padd missing semi-colon * address input review comments * Localize the back button for <PanelHeader/> * Use normal button style for signing into Firefox Account * Simplify button CSS when using button icons This does a few things: * Makes the <PanelHeader/>'s back button bigger so people have an easier time clicking it * Sets line-height of buttons to 1 to ensure that icons are vertically centered (this is ok because the labels never wrap anyway) * Adjusts the vertical alignment of icons when there's a label next to them For text-only buttons, there should be no visual changes whatsoever. * Use a "ghost" button with some custom styling for the "copy" button * Remove "link" button theme * Add missing semicolon * Move `grid-column-start` definition for the main toolbar to the proper place * Move font-size definition for the main toolbar to a better spot * Fix tests * Updated waits for integration tests. * Fix integration test flake8 errors. * Input focus state should be higher priority than input hover state! * Improve styles for management page's <ItemFilter/> * fix from @jrbenny35 * Make the origin field non-monospace * add HEADLESS back * Add an external FAQ link to navigation (#387) * Replicate send-feedback to create a FAQ link component admittedly a total copy/paste job and not certain if good for long term maintenance with potential for changes (like if/when one or the other becomes something else) versus making send-feedback abstract to take two and then split out later when either one changes to be something other than a simple link :thinking_face: * redo open-faq to match send-feedback with telemetry updates * update to use common ExternalLink widget * Fix sizing of various components in the manager to allow (very!) narrow screens * Add an intro page to the manager; resolves #292 * Remove ENABLE_DOORHANGER code we won't ever want to have it not enabled from here forward, so removing the code entirely * Minor fixes before release (#407) * fix broken markdown link * change "FAQs" to "FAQ" based on recent copy text decision * change intro titles to sentence case based on recent copy text decision * remove first run warning about no data guarantee we want users to rely on this now * visually center the FxA blurbs on the home page * increase FAQ navigation link size to match toolbar sizes * add a little more space between clickable navigation items in toolbar * Extended timeout for integration tests. * Re-wrap the input item fields so they don't regress and break the page (#409) * wrap the notes text area input so it doesn't break the page * remove redundant overflow styles * Fix feedback link on docs/index (#411) Signed-off-by: Peter deHaan <peter@deseloper.com> * Added error handling to class name munger. * Allow running integration tests on Python 3.* instead of just 3.6 * Release instructions on creating a production PR (#422) * update instructions to reflect creation of a PR from master to production * set correct release date, remove unnecessary heading * more clear about how to compare master and production branches with handy link that should always work! * request explicit approval in the instructions * add handy link to releases * address nits * Update contributing URL to point to waffle, not GitHub projects (#423) * Move unit tests to test/unit/; resolves #383 * Update pytest from 3.3.0 to 3.3.1 * Update pytest-selenium from 1.11.0 to 1.11.3 * Update pytest-xdist from 1.18.2 to 1.20.1 * Convert to Date.now() to avoid NaN * Fix invalid docs/css/extra.css rule (#434) * explicitly use guest-mode app key (#436) * add integration test script runner (#400) * Don't fire an onChange event from <ScrollingList/> if the new item is already selected This resolves - in a roundabout way - an issue with clicking the "new item" placeholder entry in the item list causing the editor widget to go away. * Improve selected/focus state for the item list; resolves #414 * Add stylelintrc config * Run CSS through prettier * Add a warn-only mode for stylelint * Make Everything Build Again (#470) * Add stylelintrc config * Run CSS through prettier * Add a warn-only mode for stylelint * make everything build again * Pulls version from package.json and appends to survey link * Update dependencies (2018-01) (#472) * Fix for failing builds on travisci (#474) * Ensure that updating the fields in <EditItemDetails/> actually triggers a UI change This helps bullet-proof our code for issues like #438, though the next commit will resolve this in a different way (by disabling the new button during editing). * Disable the "new item" button when editing an existing item; resolves #438 * initial test plan for our telemetry work * Fix <ScrollingList/> prop types; resolves #451 * Update dependencies to enable Greenkeeper 🌴 (#304) * Update Release Notes and Version to 0.5.1 (#501) * Implement a better copy-to-clipboard button; resolves #318 * Fix spurious warning from <ItemDetailsPanel/> test * Add timeout test for <CopyToClipboardButton/> * Remove unused <ErrorMessage/>; resolves #240 * chore(package): update style-loader to version 0.20.1 Closes #502 * Display More Profile Information (#486) * Implement light vs. full signout (#506) * Add a <Link/> widget and ensure that it (and <ExternalLink/>) are keyboard-accessible * Implement a dropdown for the account label; resolves #442 * Update button's focus CSS to match spec * Change <Link/>'s implementation to use a button This ensure that we don't see a spurious URL in the bottom of the window (generated by Firefox) in the bottom of the window. * Fix scrolling in management view (#531) * update to version 0.1.6-alpha (#527) * Update eslint-plugin-mozilla to the latest version 🚀 (#509) * chore(package): update events to version 2.0.0 (#511) * chore(package): update babel-minify-webpack-plugin to version 0.3.0 (#525) * chore(package): update eslint-plugin-node to version 6.0.0 (#518) * Fix: guest mode does not work on restart (#543) * pin and ignore to eslint-plugin-mozilla@0.6.0 (#546) * Refresh OAuth Access Tokens (#547) * Styling adjustments for the account dropdown. (#549) * Update Version and Release Notes to 0.1.7-alpha (#558) * chore(package): update eslint-plugin-no-unsanitized to version 3.0.0 (#537) * chore(package): update mocha to version 5.0.1 (#544) * chore(package): update stylelint to version 9.1.1 (#566) * chore(package): update stylelint-config-recommended to version 2.1.0 (#551) * Add Support For Telemetry Scalars; Update Metrics.md (#552) * Provide documentation about how to post PRs (#507) * Ensure FxA account is stored always (#570) * Update Version and Release Notes to 0.1.7-alpha1 (#571) * Updated text color of entry list empty state for better contrast (#560) * Add config file for pyup.io to update weekly (#586) * create pyup.io config file * update all dependencies, not just security * remove extra whitespace * Update flake8-isort from 2.2.2 to 2.4 (#587) * Update pytest from 3.3.1 to 3.4.1 (#589) * Update pytest-selenium from 1.11.3 to 1.11.4 (#590) * Update pypom from 1.2.0 to 1.3.0 (#594) * Update selenium from 3.8.0 to 3.9.0 (#592) * Update pytest-xdist from 1.20.1 to 1.22.2 (#591) * Update flake8-docstrings from 1.1.0 to 1.3.0 (#588) * More account dropdown style updates (#597) * Styling updates based off Jim's code review of #549 -Updated pseudo-elements to have two colons instead of one -Moved toolbar margin update to be specific to navigation bar -Removed arrowhead down icon that is no longer in use -Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items * Updating toolbar to use px instead of ch to be consistent. * Include whitespace in item fields so new lines are output (#596) * Include whitespace in item fields so new lines are output * move white-space to all input text fields * Automatically focus the filter input when the page loads; resolves #573 * Styling updates around entry list items (#553) * Styling updates around entry list items -Active and focus states -Increased padding to match mocks -New chevron icon -Updated aside background color -Moved border between search and entries in order to apply active border color to top entry item -Small copy change to empty state * Changes based off PR feedback -Removed arrowhead right icon that is no longer used -Removed some styling around border between filter and list items until we get the filter updated. * Add custom "no username" instruction text when adding entry * Remove string interpolation and use better const name * Ran cheveron-right through svgo, sizing was also updated. * update to latest package-lock.json after production branch merge to get the two branches up to date and matching each other they diverged and production became 95 commits behind and 5 ahead due to rename/delete conflicts and I "took" the conflicting changes from production to the package-lock file, now I want the actual latest result of `npm i` * Updating styling of 0 entries (home) page to reflect intended typography and spacing (#607) - Into image shadow to Shadow 10 - Updated image border - Defined line height for intro paragraphs * Create a <PanelFooterButton/> and update the styles for the unlock do… (#601) * Create a <PanelFooterButton/> and update the styles for the unlock doorhanger; resolves #482 * latest Nessie with darker waves * Update selenium from 3.9.0 to 3.10.0 * chore(package): update documentation to version 6.0.0 * Require python 3.6 in deploy stage so pip can install tornado * Create/Edit Entry Details Styling Adjustments (#567) * Styling adjustments for entry details -Added show/hide icons for password -Reordered fields to match new designs -Removed monospace class from username field -Fixed sizing/spacing to match designs -Updated to use box-sizing: border box, and fixed issues this caused in other areas -Updated placeholder copy and labels to match design changes -Added min-width to buttons * Adding min-width to normal button style and larger min-width for primary buttons * Styling for dialog box and adding new critical/red button style * Changes based on PR review -ran svgo on show icon to optimize -created new notes class in entry details for styling -removed box sizing and associated style changes -moved password styles to input.css -Removed show/hide button text and keys -Changed critical theme to danger theme -Reverted dialog to use primary button by default * Re-localize the show/hide password input buttons * Fix input tests to also check for first "input" class * Better RegEx for munged password input class tests * Fixing missed styles from box-sizing removal that needed updated * Provide the option of using "danger" buttons in dialog boxes These are currently used in two places: * Deleting items * Resetting the datastore * restore indentation * Fixes based on PR changes requested -Ran show icon through svgo -Moved input max-width for entry creation/edition fields to item-fields.css -Created new "wide" button sub-theme for instances to include min-width property -Added size theme to save/edit button on entry details * Adding .input class to item fields for styling and removing unnecessary selector * Improvements to search bar styling in full manage mode (#562) * Styling adjustments for entry list filter. -Added search icon -Updated padding/colors -Included clear icon but needs implemented -Removed "entries" from placeholder copy * Styling updates for entries list filter in aside -Fixed padding/sizing to match design -Added search icon -Replaced text link with 'clear icon' -Updated placeholder copy to 'search lockbox' * Changes after review with Ryan -Darkening placeholder text -Updated border radius on inputs -Reverting search to use regular weight * Moving location of styles for filter/search in order to cover both doorhanger and full page view * Adding MPL-2.0 license to item-filter file and new line on app.css * Updates based on PR feedback -Added new line at end of SVG files -Removed item-filter.css and moved styles to input.css file -Wrapped filter in <toolbar> element and applied padding there -Added title attribute to clear button * Removing "clear" text from filter button * Update input test regex to include first input filter class * Restore localization of "Clear" text on search * Better RegEx for munged input class tests * Removed some unnecessary styles left behind and updated padding for consistency. * Ran clear and search svgs through svgo * Restore filter styles lost in master branch merge 28e31d5 * Make sure options_ui is fully displayed on about:addons (#603) * Make sure options_ui is fully displayed on about:addons * flex-direction is actually not necessary, not sure why i ended up with it * add margin so button focus state fits and text aligns with items above * add min-height to give the warning dialog more room to breathe * added accessibility test plan to docs * Attempt to speed up branch and PR builds with Travis CI caching (#604) * Speed up branch and PR builds with Travis CI caching * add pip cache * Styling adjustment to align entry detail buttons during edit and view mode change (#608) * Fix <ItemFilter/> to actually update its state from Redux * Fix importing of chai-enzyme in <ButtonStack/> test * Automatically select the filter input's text on load (if there is any) * Pre-fill the URL of the current tab into the doorhanger's filter * Prepare 0.1.8 release (#612) * bump version numbers to 0.1.8-alpha * draft release notes based on current progress and fixed release note headings in previous release * recent additions for release notes * last items included in this release * remove depdencies updates from release notes
kimberlythegeek
added a commit
to kimberlythegeek/lockbox-extension
that referenced
this pull request
Mar 21, 2018
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: # This is a combination of 9 commits. # This is the 1st commit message: # This is a combination of 15 commits. # This is the 1st commit message: # This is a combination of 49 commits. # This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: # This is a combination of 25 commits. # This is the 1st commit message: flake8 # This is the commit message mozilla-lockwise#2: Refresh OAuth Access Tokens (mozilla-lockwise#547) # This is the commit message mozilla-lockwise#3: Styling adjustments for the account dropdown. (mozilla-lockwise#549) # This is the commit message mozilla-lockwise#4: Update Version and Release Notes to 0.1.7-alpha (mozilla-lockwise#558) # This is the commit message mozilla-lockwise#5: chore(package): update eslint-plugin-no-unsanitized to version 3.0.0 (mozilla-lockwise#537) # This is the commit message mozilla-lockwise#6: chore(package): update mocha to version 5.0.1 (mozilla-lockwise#544) # This is the commit message mozilla-lockwise#7: chore(package): update stylelint to version 9.1.1 (mozilla-lockwise#566) # This is the commit message mozilla-lockwise#8: chore(package): update stylelint-config-recommended to version 2.1.0 (mozilla-lockwise#551) # This is the commit message mozilla-lockwise#9: Add Support For Telemetry Scalars; Update Metrics.md (mozilla-lockwise#552) # This is the commit message mozilla-lockwise#10: Provide documentation about how to post PRs (mozilla-lockwise#507) # This is the commit message mozilla-lockwise#11: Ensure FxA account is stored always (mozilla-lockwise#570) # This is the commit message mozilla-lockwise#12: Update Version and Release Notes to 0.1.7-alpha1 (mozilla-lockwise#571) # This is the commit message mozilla-lockwise#13: Updated text color of entry list empty state for better contrast (mozilla-lockwise#560) # This is the commit message mozilla-lockwise#14: Add config file for pyup.io to update weekly (mozilla-lockwise#586) * create pyup.io config file * update all dependencies, not just security * remove extra whitespace # This is the commit message mozilla-lockwise#15: Update flake8-isort from 2.2.2 to 2.4 (mozilla-lockwise#587) # This is the commit message mozilla-lockwise#16: Update pytest from 3.3.1 to 3.4.1 (mozilla-lockwise#589) # This is the commit message mozilla-lockwise#17: Update pytest-selenium from 1.11.3 to 1.11.4 (mozilla-lockwise#590) # This is the commit message mozilla-lockwise#18: Update pypom from 1.2.0 to 1.3.0 (mozilla-lockwise#594) # This is the commit message mozilla-lockwise#19: Update selenium from 3.8.0 to 3.9.0 (mozilla-lockwise#592) # This is the commit message mozilla-lockwise#20: Update pytest-xdist from 1.20.1 to 1.22.2 (mozilla-lockwise#591) # This is the commit message mozilla-lockwise#21: Update flake8-docstrings from 1.1.0 to 1.3.0 (mozilla-lockwise#588) # This is the commit message mozilla-lockwise#22: More account dropdown style updates (mozilla-lockwise#597) * Styling updates based off Jim's code review of mozilla-lockwise#549 -Updated pseudo-elements to have two colons instead of one -Moved toolbar margin update to be specific to navigation bar -Removed arrowhead down icon that is no longer in use -Updated dropdown hover, focus and active states after reviewing how Firefox browser handles similar items * Updating toolbar to use px instead of ch to be consistent. # This is the commit message mozilla-lockwise#23: Include whitespace in item fields so new lines are output (mozilla-lockwise#596) * Include whitespace in item fields so new lines are output * move white-space to all input text fields # This is the commit message mozilla-lockwise#24: Automatically focus the filter input when the page loads; resolves mozilla-lockwise#573 # This is the commit message mozilla-lockwise#25: Styling updates around entry list items (mozilla-lockwise#553) * Styling updates around entry list items -Active and focus states -Increased padding to match mocks -New chevron icon -Updated aside background color -Moved border between search and entries in order to apply active border color to top entry item -Small copy change to empty state * Changes based off PR feedback -Removed arrowhead right icon that is no longer used -Removed some styling around border between filter and list items until we get the filter updated. * Add custom "no username" instruction text when adding entry * Remove string interpolation and use better const name * Ran cheveron-right through svgo, sizing was also updated. # This is the commit message mozilla-lockwise#2: 0.1.7-alpha1 (mozilla-lockwise#574) # This is the commit message mozilla-lockwise#2: Updating styling of 0 entries (home) page to reflect intended typography and spacing (mozilla-lockwise#607) - Into image shadow to Shadow 10 - Updated image border - Defined line height for intro paragraphs # This is the commit message mozilla-lockwise#3: Create a <PanelFooterButton/> and update the styles for the unlock do… (mozilla-lockwise#601) * Create a <PanelFooterButton/> and update the styles for the unlock doorhanger; resolves mozilla-lockwise#482 * latest Nessie with darker waves # This is the commit message mozilla-lockwise#4: Update selenium from 3.9.0 to 3.10.0 # This is the commit message mozilla-lockwise#5: chore(package): update documentation to version 6.0.0 # This is the commit message mozilla-lockwise#6: Require python 3.6 in deploy stage so pip can install tornado # This is the commit message mozilla-lockwise#7: Create/Edit Entry Details Styling Adjustments (mozilla-lockwise#567) * Styling adjustments for entry details -Added show/hide icons for password -Reordered fields to match new designs -Removed monospace class from username field -Fixed sizing/spacing to match designs -Updated to use box-sizing: border box, and fixed issues this caused in other areas -Updated placeholder copy and labels to match design changes -Added min-width to buttons * Adding min-width to normal button style and larger min-width for primary buttons * Styling for dialog box and adding new critical/red button style * Changes based on PR review -ran svgo on show icon to optimize -created new notes class in entry details for styling -removed box sizing and associated style changes -moved password styles to input.css -Removed show/hide button text and keys -Changed critical theme to danger theme -Reverted dialog to use primary button by default * Re-localize the show/hide password input buttons * Fix input tests to also check for first "input" class * Better RegEx for munged password input class tests * Fixing missed styles from box-sizing removal that needed updated * Provide the option of using "danger" buttons in dialog boxes These are currently used in two places: * Deleting items * Resetting the datastore * restore indentation * Fixes based on PR changes requested -Ran show icon through svgo -Moved input max-width for entry creation/edition fields to item-fields.css -Created new "wide" button sub-theme for instances to include min-width property -Added size theme to save/edit button on entry details * Adding .input class to item fields for styling and removing unnecessary selector # This is the commit message mozilla-lockwise#8: Improvements to search bar styling in full manage mode (mozilla-lockwise#562) * Styling adjustments for entry list filter. -Added search icon -Updated padding/colors -Included clear icon but needs implemented -Removed "entries" from placeholder copy * Styling updates for entries list filter in aside -Fixed padding/sizing to match design -Added search icon -Replaced text link with 'clear icon' -Updated placeholder copy to 'search lockbox' * Changes after review with Ryan -Darkening placeholder text -Updated border radius on inputs -Reverting search to use regular weight * Moving location of styles for filter/search in order to cover both doorhanger and full page view * Adding MPL-2.0 license to item-filter file and new line on app.css * Updates based on PR feedback -Added new line at end of SVG files -Removed item-filter.css and moved styles to input.css file -Wrapped filter in <toolbar> element and applied padding there -Added title attribute to clear button * Removing "clear" text from filter button * Update input test regex to include first input filter class * Restore localization of "Clear" text on search * Better RegEx for munged input class tests * Removed some unnecessary styles left behind and updated padding for consistency. * Ran clear and search svgs through svgo * Restore filter styles lost in master branch merge 28e31d5 # This is the commit message mozilla-lockwise#9: Make sure options_ui is fully displayed on about:addons (mozilla-lockwise#603) * Make sure options_ui is fully displayed on about:addons * flex-direction is actually not necessary, not sure why i ended up with it * add margin so button focus state fits and text aligns with items above * add min-height to give the warning dialog more room to breathe # This is the commit message mozilla-lockwise#10: added accessibility test plan to docs # This is the commit message mozilla-lockwise#11: Attempt to speed up branch and PR builds with Travis CI caching (mozilla-lockwise#604) * Speed up branch and PR builds with Travis CI caching * add pip cache # This is the commit message mozilla-lockwise#12: writing jenkins config # This is the commit message mozilla-lockwise#13: fixed typo # This is the commit message mozilla-lockwise#14: edited jenkins config # This is the commit message mozilla-lockwise#15: edited jenkins config # This is the commit message mozilla-lockwise#16: edited jenkins config # This is the commit message mozilla-lockwise#17: edited jenkins config # This is the commit message mozilla-lockwise#18: edited jenkins config # This is the commit message mozilla-lockwise#19: edited jenkins config # This is the commit message mozilla-lockwise#20: edited jenkins config # This is the commit message mozilla-lockwise#21: edited jenkins config # This is the commit message mozilla-lockwise#22: edited jenkins config # This is the commit message mozilla-lockwise#23: edited jenkins config # This is the commit message mozilla-lockwise#24: edited jenkins config # This is the commit message mozilla-lockwise#25: added jenkins build script # This is the commit message mozilla-lockwise#26: edited jenkins config # This is the commit message mozilla-lockwise#27: edited jenkins config # This is the commit message mozilla-lockwise#28: edited jenkins config # This is the commit message mozilla-lockwise#29: edited jenkins config # This is the commit message mozilla-lockwise#30: edited jenkins config # This is the commit message mozilla-lockwise#31: edited jenkins config # This is the commit message mozilla-lockwise#32: edited jenkins config # This is the commit message mozilla-lockwise#33: edited jenkins config # This is the commit message mozilla-lockwise#34: edited jenkins config # This is the commit message mozilla-lockwise#35: including a11y tests # This is the commit message mozilla-lockwise#36: flake8 # This is the commit message mozilla-lockwise#37: flake8 # This is the commit message mozilla-lockwise#38: removed pypom from test reqs # This is the commit message mozilla-lockwise#39: edited jenkins config # This is the commit message mozilla-lockwise#40: edited jenkins config # This is the commit message mozilla-lockwise#41: edited jenkins config # This is the commit message mozilla-lockwise#42: edited jenkins config # This is the commit message mozilla-lockwise#43: edited jenkins config # This is the commit message mozilla-lockwise#44: Styling adjustment to align entry detail buttons during edit and view mode change (mozilla-lockwise#608) # This is the commit message mozilla-lockwise#45: Fix <ItemFilter/> to actually update its state from Redux # This is the commit message mozilla-lockwise#46: Fix importing of chai-enzyme in <ButtonStack/> test # This is the commit message mozilla-lockwise#47: Automatically select the filter input's text on load (if there is any) # This is the commit message mozilla-lockwise#48: Pre-fill the URL of the current tab into the doorhanger's filter # This is the commit message mozilla-lockwise#49: Prepare 0.1.8 release (mozilla-lockwise#612) * bump version numbers to 0.1.8-alpha * draft release notes based on current progress and fixed release note headings in previous release * recent additions for release notes * last items included in this release * remove depdencies updates from release notes # This is the commit message mozilla-lockwise#2: Fix the color of the horizontal line in the item details of the manager # This is the commit message mozilla-lockwise#3: edited jenkins config # This is the commit message mozilla-lockwise#4: edited jenkins config # This is the commit message mozilla-lockwise#5: edited jenkins config # This is the commit message mozilla-lockwise#6: edited jenkins config # This is the commit message mozilla-lockwise#7: edited jenkins config # This is the commit message mozilla-lockwise#8: edited jenkins config # This is the commit message mozilla-lockwise#9: edited jenkins config # This is the commit message mozilla-lockwise#10: edited jenkins config # This is the commit message mozilla-lockwise#11: edited jenkins config # This is the commit message mozilla-lockwise#12: edited jenkins config # This is the commit message mozilla-lockwise#13: edited jenkins config # This is the commit message mozilla-lockwise#14: Move python runtime for deploy stage out of 'on' requirement So the pages actually build using python 3.6 instead of just checking to make sure its in the 3.6 runtime # This is the commit message mozilla-lockwise#15: Downgrade Travis deploy script to fix pages deploy See travis-ci/travis-ci#9312 # This is the commit message mozilla-lockwise#2: Improve implementation of <Stack/> (formerly <ButtonStack/>) Unfortunately, to have behavior like <xul:deck>, the only way I can figure out is just to use the XUL box model. :( # This is the commit message mozilla-lockwise#3: Allow greater customization of <CopyToClipboardButton/> # This is the commit message mozilla-lockwise#4: Provide visuals for the quick-copy buttons in the doorhanger list view # This is the commit message mozilla-lockwise#5: Add support for copying the username and password from the quick-copy buttons # This is the commit message mozilla-lockwise#6: Add telemetry for the quick-copy buttons # This is the commit message mozilla-lockwise#7: Address styling concerns # This is the commit message mozilla-lockwise#8: Add tests for quick-copy behavior # This is the commit message mozilla-lockwise#9: Address mozilla-lockwise#570 Post-Merge Code Review Comments (mozilla-lockwise#647) # This is the commit message mozilla-lockwise#2: changes to metrics # This is the commit message mozilla-lockwise#3: Update stylelint to the latest version 🚀 (mozilla-lockwise#658) * chore(package): update stylelint to version 9.1.2 * chore(package): update stylelint to version 9.1.3 # This is the commit message mozilla-lockwise#2: Update flake8-isort from 2.4 to 2.5 (mozilla-lockwise#671) # This is the commit message mozilla-lockwise#2: Docs are wrong becuase sync is not currently supported fixes mozilla-lockwise#670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #480
-
Modified password read only char code to match design-Fixed issue where bottom buttons would jump a bit from edit to view state