From 8437602497612a0ae212a3c5e0851989ac5bf279 Mon Sep 17 00:00:00 2001
From: Nick Brandt <nbrandt@mozilla.com>
Date: Fri, 2 Mar 2018 17:25:40 -0700
Subject: [PATCH 1/4] Styling to align entry details to designs

-Modified password read only char code to match design
-Fixed issue where bottom buttons would jump a bit from edit to view state
---
 src/webextension/list/components/item-fields.css | 8 ++++++++
 src/webextension/list/components/item-fields.js  | 6 +++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/webextension/list/components/item-fields.css b/src/webextension/list/components/item-fields.css
index d482650c..2145781e 100644
--- a/src/webextension/list/components/item-fields.css
+++ b/src/webextension/list/components/item-fields.css
@@ -29,6 +29,10 @@
   min-height: 60px;
 }
 
+.notes-read-only {
+  min-height: 73px;
+}
+
 .first-label {
   margin-top: 0;
 }
@@ -40,3 +44,7 @@
 .inline-button > *:first-child {
   flex: 1;
 }
+
+.password {
+  font-weight: normal;
+}
diff --git a/src/webextension/list/components/item-fields.js b/src/webextension/list/components/item-fields.js
index 52ac1dda..bf3d5f05 100644
--- a/src/webextension/list/components/item-fields.js
+++ b/src/webextension/list/components/item-fields.js
@@ -15,7 +15,7 @@ import TextArea from "../../widgets/text-area";
 
 import styles from "./item-fields.css";
 
-const PASSWORD_DOT = "\u25cf";
+const PASSWORD_DOT = "\u2022";
 
 const fieldsPropTypes = PropTypes.shape({
   origin: PropTypes.string.isRequired,
@@ -61,7 +61,7 @@ export function ItemFields({fields, onCopy}) {
           <LabelText>pASSWORd</LabelText>
         </Localized>
         <div className={styles.inlineButton}>
-          <FieldText monospace data-name="password">
+          <FieldText className={styles.password} monospace data-name="password">
             {PASSWORD_DOT.repeat(fields.password.length)}
           </FieldText>
           <Localized id="item-fields-copy-password">
@@ -74,7 +74,7 @@ export function ItemFields({fields, onCopy}) {
         <Localized id="item-fields-notes">
           <LabelText>nOTEs</LabelText>
         </Localized>
-        <FieldText className={styles.notes} data-name="notes">{fields.notes}</FieldText>
+        <FieldText className={styles.notesReadOnly} data-name="notes">{fields.notes}</FieldText>
       </div>
     </div>
   );

From 68f953bdd6db6be6b6d1de66d6566b33610af379 Mon Sep 17 00:00:00 2001
From: Nick Brandt <nbrandt@mozilla.com>
Date: Mon, 5 Mar 2018 14:35:51 -0700
Subject: [PATCH 2/4] Reverting password dot change as it creates
 inconsistencies on Win and Linux

---
 src/webextension/list/components/item-fields.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/webextension/list/components/item-fields.js b/src/webextension/list/components/item-fields.js
index bf3d5f05..b26bdadf 100644
--- a/src/webextension/list/components/item-fields.js
+++ b/src/webextension/list/components/item-fields.js
@@ -15,7 +15,7 @@ import TextArea from "../../widgets/text-area";
 
 import styles from "./item-fields.css";
 
-const PASSWORD_DOT = "\u2022";
+const PASSWORD_DOT = "\u25cf";
 
 const fieldsPropTypes = PropTypes.shape({
   origin: PropTypes.string.isRequired,

From 0cf3b8f82fccdae312d61847784bb13c3b8cf1d2 Mon Sep 17 00:00:00 2001
From: Nick Brandt <nbrandt@mozilla.com>
Date: Tue, 6 Mar 2018 12:02:13 -0700
Subject: [PATCH 3/4] Removing unnecessary font weight for password

---
 src/webextension/list/components/item-fields.css | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/webextension/list/components/item-fields.css b/src/webextension/list/components/item-fields.css
index 2145781e..171a7a83 100644
--- a/src/webextension/list/components/item-fields.css
+++ b/src/webextension/list/components/item-fields.css
@@ -44,7 +44,3 @@
 .inline-button > *:first-child {
   flex: 1;
 }
-
-.password {
-  font-weight: normal;
-}

From 41c2f78b9e8945872e35557e7c93b84945fc06e4 Mon Sep 17 00:00:00 2001
From: Devin Reams <devin@reams.me>
Date: Tue, 6 Mar 2018 13:45:40 -0700
Subject: [PATCH 4/4] password styles on the element are also unncessary

---
 src/webextension/list/components/item-fields.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/webextension/list/components/item-fields.js b/src/webextension/list/components/item-fields.js
index b26bdadf..97b9c1fc 100644
--- a/src/webextension/list/components/item-fields.js
+++ b/src/webextension/list/components/item-fields.js
@@ -61,7 +61,7 @@ export function ItemFields({fields, onCopy}) {
           <LabelText>pASSWORd</LabelText>
         </Localized>
         <div className={styles.inlineButton}>
-          <FieldText className={styles.password} monospace data-name="password">
+          <FieldText monospace data-name="password">
             {PASSWORD_DOT.repeat(fields.password.length)}
           </FieldText>
           <Localized id="item-fields-copy-password">