-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use dnsmasq for translations generic worker #149
base: main
Are you sure you want to change the base?
Conversation
Hopefully a fix for mozilla/translations#549
Managed to build with this today. I got a working image, but it's causing seemingly harmless DNS resolution issues in later steps of the build:
The image still builds, and works fine, but quite clearly DNS resolution that relies on the search domain being set properly does not work with this patch. Ideally, whatever dhcp client is being used would dump this information out somewhere, and we could point dnsmasq at that -- but I'm not sure what's doing that. |
@aerickson - I realize this is most likely not landable, but I'd appreciate any thoughts or insight you have here. |
I think it's just the packer ssh session that is still trying to use the systemd resolver (new processes are fine). If it builds fine and name resolutions work I think it's fine (we could add a note in the dnsmasq script that the errors are non-fatal). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LMK if you'd like me to make a build. I noticed gw-translations-gcp-googlecompute-2024-10-10t20-47-51z
that you might have created when testing.
In the We can try a build, yeah. I can give it a quick a sanity check, but I don't expect we'll know if the issue is truly fixed until it's in production for awhile. |
You're right, you only have
Sounds good. Will do a build. (Not sure if the image above is good, so I'll make a new one.) |
Built |
This image seems to be causing issues for reasons unrelated to dnsmasq. We're getting errors from marian like:
marian-nmt/marian-dev#666 seems to suggest that this is a mismatch between the CUDA that Marian was compiled against and what's being used at runtime. The SBOM seems to confirm this: we have 12.6.2 installed on image, but we compiled Marian against 12.1.0: https://github.com/mozilla/firefox-translations-training/blob/d1d1efc441bfa9fc0f3e2c176f778197d16899df/taskcluster/kinds/fetch/toolchains.yml#L45-L52. I'm going to try bumping the latter. |
Hopefully a fix for mozilla/translations#549
I haven't had a chance to test out an image build with this myself yet.