Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Win HG data lookups #521

Open
markcor opened this issue Jun 29, 2023 · 1 comment
Open

Move Win HG data lookups #521

markcor opened this issue Jun 29, 2023 · 1 comment
Assignees

Comments

@markcor
Copy link
Contributor

markcor commented Jun 29, 2023

The lookup's in the Windows package Mercurial manifest should be in the common tools profile.

@markcor
Copy link
Contributor Author

markcor commented Jun 29, 2023

Typically lookups should be done the in the profile that calls the class. This is the case for other data as well. Such as non typical installation directories should be set in the profile. An example would be https://github.com/mozilla-platform-ops/ronin_puppet/blob/cloud_windows/modules/win_packages/manifests/custom_nssm.pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants