Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coveralls dependencies #449

Merged
merged 8 commits into from
Dec 7, 2021

Conversation

gbrownmozilla
Copy link
Contributor

Closes #444

@gbrownmozilla gbrownmozilla self-assigned this Dec 6, 2021
@gbrownmozilla gbrownmozilla marked this pull request as draft December 6, 2021 20:13
@gbrownmozilla
Copy link
Contributor Author

Let's go with this for now: resolve the dependency problems so each script fails the same way, once it tries to submit data to coveralls.io. I will file a new issue for the bigger issue of getting coveralls really working.

@gbrownmozilla gbrownmozilla changed the title Fix coveralls Fix coveralls dependencies Dec 7, 2021
Copy link
Contributor

@escapewindow escapewindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@escapewindow escapewindow marked this pull request as ready for review December 7, 2021 23:14
@gbrownmozilla gbrownmozilla merged commit 8ee01aa into mozilla-releng:master Dec 7, 2021
@gbrownmozilla gbrownmozilla deleted the fix-coveralls branch December 7, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pushmsixscript] non-fatal tox failure
2 participants