Skip to content

Commit

Permalink
correct our CMD in the main Dockerfile (#1061)
Browse files Browse the repository at this point in the history
This change will mean autograph will correctly see SIGTERM and SIGKILL
signals coming from systemd and kubernetes. This may change its behavior
somewhat, but, long term, for the better.

This fixes the warning we were getting from docker when building our main Dockerfile:

```
- JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 86)
```

See https://docs.docker.com/reference/build-checks/json-args-recommended/
  • Loading branch information
jmhodges authored Nov 8, 2024
1 parent 6d1fc24 commit 572915c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,5 @@ COPY --from=builder /tmp/libkmsp11.so /app
RUN useradd --uid 10001 --home-dir /app --shell /sbin/nologin app
USER app
WORKDIR /app
CMD /go/bin/autograph
CMD ["/go/bin/autograph"]

0 comments on commit 572915c

Please sign in to comment.