Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Server should check if application_key is raw. #1361

Open
jrconlin opened this issue Feb 24, 2020 · 0 comments
Open

Server should check if application_key is raw. #1361

jrconlin opened this issue Feb 24, 2020 · 0 comments
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. enhancement

Comments

@jrconlin
Copy link
Member

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/7345332/events/39318554/

Clients sending an unencoded application_key can trigger a base64 decode error. Server should helpfully check if the key is raw format or at least fail out with a better message indicating the error.
@jrconlin jrconlin added the 3 Estimate - m - This is a small change, but there's some uncertainty. label Feb 24, 2020
@tublitzed tublitzed changed the title Server should check if applicaiton_key is raw. Server should check if application_key is raw. Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrconlin