This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Add connection timeouts for APNS #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1394 +/- ##
==========================================
- Coverage 99.74% 99.72% -0.02%
==========================================
Files 64 64
Lines 10476 10537 +61
==========================================
+ Hits 10449 10508 +59
- Misses 27 29 +2
Continue to review full report at Codecov.
|
AzureMarker
reviewed
Jun 25, 2020
|
NOTE: going to ice this PR for the time being. After discussions with @pjenvey, this hack may work, but what's really needed is more visibility into whatever error may actually be occurring. The HTTP2 library we use is fairly robust and should be able to handle any invalid state naturally. Keeping this PR and branch in reserve in case it's needed. |
jrconlin
added a commit
that referenced
this pull request
Jun 25, 2020
Issue #1393 notes, sending push messages across APNS seems to work great after a deploy, but then degrades after a week or so. #1394 is a possible work-around (by double-pooling connections and using a dedicated connection terminator), but it's messy and hacky. What's really needed is a bit more visibility into what may be happening, and that will involve logging all APNS communication exceptions reliably. Issue #1393
jrconlin
added a commit
that referenced
this pull request
Jul 1, 2020
Issue #1393 notes, sending push messages across APNS seems to work great after a deploy, but then degrades after a week or so. #1394 is a possible work-around (by double-pooling connections and using a dedicated connection terminator), but it's messy and hacky. What's really needed is a bit more visibility into what may be happening, and that will involve logging all APNS communication exceptions reliably. Issue #1393
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1393
Description
I don't believe that these connections are being closed, and eventually we wind up with old, mostly idle connections that Apple frowns upon. Also, APNS is not really "heavy use" so we can probably turn off the pre-connection pool and just connect when need be.
TODO:
find a better reaper than just calling out to Thread.
Testing
There are unit tests. With debugging enabled, idle connections should time out after about 5 min.
Issue(s)
Closes #1393.