From 96a1593f2c60decfd63c0ae6088e9e6e72733a07 Mon Sep 17 00:00:00 2001 From: Will Kahn-Greene Date: Tue, 3 Oct 2023 10:41:06 -0400 Subject: [PATCH 1/3] Fix linting make rule --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 657525f..ad75b3f 100644 --- a/Makefile +++ b/Makefile @@ -16,8 +16,8 @@ clean: ## Clean build artifacts .PHONY: lint lint: ## Lint and black reformat files - black --target-version=py37 --line-length=88 setup.py src tests - tox -e py37-lint + black setup.py src tests + tox -e py38-lint .PHONY: test test: ## Run tests From 52959246601f1399746dfec803b241a34122614c Mon Sep 17 00:00:00 2001 From: Will Kahn-Greene Date: Tue, 3 Oct 2023 10:42:35 -0400 Subject: [PATCH 2/3] Add support for Python 3.12 (#91) --- .github/workflows/main.yml | 2 +- pyproject.toml | 2 ++ setup.py | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index db92771..10a3170 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -15,7 +15,7 @@ jobs: strategy: matrix: - python-version: ['3.8', '3.9', '3.10', '3.11'] + python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] name: Python ${{ matrix.python-version}} steps: diff --git a/pyproject.toml b/pyproject.toml index 31c0871..859748b 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -28,6 +28,7 @@ envlist = py39 py310 py311 + py312 [gh-actions] python = @@ -35,6 +36,7 @@ python = 3.9: py39 3.10: py310 3.11: py311 + 3.12: py312 [testenv] deps = -rrequirements-dev.txt diff --git a/setup.py b/setup.py index ddb0f8b..5b3f8d3 100644 --- a/setup.py +++ b/setup.py @@ -56,6 +56,7 @@ def get_version(): "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", + "Programming Language :: Python :: 3.12", "Programming Language :: Python :: Implementation :: CPython", "Topic :: Software Development :: Libraries :: Python Modules", ], From 009f3835ce53f46edc2568c58ecc4251462b8098 Mon Sep 17 00:00:00 2001 From: Will Kahn-Greene Date: Tue, 3 Oct 2023 10:54:29 -0400 Subject: [PATCH 3/3] Update dev dependencies; fix linting issue --- requirements-dev.txt | 16 ++++++++-------- src/crashstats_tools/cmd_fetch_data.py | 1 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/requirements-dev.txt b/requirements-dev.txt index 636c162..3332d4a 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -1,14 +1,14 @@ -e . -black==22.10.0 -build==0.9.0 +black==23.9.1 +build==1.0.3 check-manifest==0.49 cogapp==3.3.0 freezegun==1.2.2 -pytest==7.2.0 -responses==0.22.0 -ruff==0.0.262 -tox==3.27.1 -tox-gh-actions==2.11.0 +pytest==7.4.2 +responses==0.23.3 +ruff==0.0.292 +tox==4.11.3 +tox-gh-actions==3.1.3 twine==4.0.2 -wheel==0.38.4 +wheel==0.41.2 diff --git a/src/crashstats_tools/cmd_fetch_data.py b/src/crashstats_tools/cmd_fetch_data.py index af3e6e6..049b6c5 100644 --- a/src/crashstats_tools/cmd_fetch_data.py +++ b/src/crashstats_tools/cmd_fetch_data.py @@ -64,7 +64,6 @@ def fetch_crash( # Fetch dumps for dump_name in dump_names: - # We store "upload_file_minidump" as "dump", so we need to use that # name when requesting from the RawCrash api file_name = dump_name