Skip to content

Commit

Permalink
Merge pull request #17 from mozilla-services/support-for-abbr-commit-…
Browse files Browse the repository at this point in the history
…shas-in-incidents

Support abbreviated Git Commit SHAs in incidents.sql
  • Loading branch information
dlactin authored May 30, 2024
2 parents 58f2e1e + 8bd2a48 commit 693486d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion queries/incidents.sql
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ LEFT JOIN (
) AS root
ON
service_catalog.service = root.service
AND root_cause = root.changes
-- root.changes are full Git Commit SHAs in deployment_status events.
-- root_cause are either full or abbreviated Git Commit SHAs in incident events.
AND STARTS_WITH(root.changes, root_cause)
-- GitHub and PagerDuty incidents don't contain information about the environment.
-- Google Form incidents are always reported for the `production` environment.
-- The following ensures we don't correlate incidents with `staging` deployments.
Expand Down

0 comments on commit 693486d

Please sign in to comment.