fixup syncstorage-mysql/src/pool.rs

syncstorage-mysql/src/pool.rs

@@ -31,13 +31,15 @@ pub const MIGRATIONS: EmbeddedMigrations = embed_migrations!();
 /// Mysql DDL statements implicitly commit which could disrupt MysqlPool's
 /// begin_test_transaction during tests. So this runs on its own separate conn.
 fn run_embedded_migrations(database_url: &str) -> DbResult<()> {
-    let mut conn = MysqlConnection::establish(database_url)?;
+    let conn = MysqlConnection::establish(database_url)?;
+
+    // This conn2 charade is to make mut-ness the same for both cases.
     #[cfg(debug_assertions)]
-    // XXX: this doesn't show the DDL statements
-    // https://github.com/shssoichiro/diesel-logger/issues/1
-    LoggingConnection::new(conn).run_pending_migrations(MIGRATIONS)?;
+    let mut conn2 = LoggingConnection::new(conn);
     #[cfg(not(debug_assertions))]
-    conn.run_pending_migrations(MIGRATIONS)?;
+    let mut conn2 = conn;
+
+    conn2.run_pending_migrations(MIGRATIONS)?;
     Ok(())
 }