bug-1827506: Rename storage timeout settings.

mozilla-services · Jul 29, 2024 · b08c54c · b08c54c
1 parent 69aac3c
commit b08c54c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tecken/ext/gcs/storage.py b/tecken/ext/gcs/storage.py
@@ -36,7 +36,7 @@ def __init__(
         # The Cloud Storage client doesn't support setting global timeouts for all requests, so we
         # need to pass the timeout for every single request. the default timeout is 60 seconds for
         # both connecting and reading from the socket.
-        self.timeout = (settings.S3_CONNECT_TIMEOUT, settings.S3_READ_TIMEOUT)
+        self.timeout = (settings.STORAGE_CONNECT_TIMEOUT, settings.STORAGE_READ_TIMEOUT)
 
     def __repr__(self):
         return f"<{self.__class__.__name__} gs://{self.bucket}/{self.prefix}> try:{self.try_symbols}"

diff --git a/tecken/ext/s3/storage.py b/tecken/ext/s3/storage.py
@@ -43,8 +43,8 @@ def _get_client(self):
         if not hasattr(self.clients, "storage"):
             options = {
                 "config": Config(
-                    read_timeout=settings.S3_READ_TIMEOUT,
-                    connect_timeout=settings.S3_CONNECT_TIMEOUT,
+                    read_timeout=settings.STORAGE_READ_TIMEOUT,
+                    connect_timeout=settings.STORAGE_CONNECT_TIMEOUT,
                 )
             }
             if self.endpoint_url:

diff --git a/tecken/settings.py b/tecken/settings.py
@@ -432,13 +432,13 @@ def filter(self, record):
         },
     }
 
-S3_CONNECT_TIMEOUT = _config(
+STORAGE_CONNECT_TIMEOUT = _config(
     "S3_LOOKUP_CONNECT_TIMEOUT",
     default="5",
     parser=int,
     doc="S3 connection timeout in seconds.",
 )
-S3_READ_TIMEOUT = _config(
+STORAGE_READ_TIMEOUT = _config(
     "S3_LOOKUP_READ_TIMEOUT",
     default="5",
     parser=int,