bug-1906959: Allow GCS buckets to be behind a CDN. #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
approved these changes
Jul 16, 2024
smarnach
force-pushed
the
storage-interface-gcs
branch
from
c23101d
to
f07eee1
Compare
smarnach
force-pushed
the
storage-interface-gcs
branch
2 times, most recently
from
0839403
to
d579d69
Compare
smarnach
force-pushed
the
storage-interface-gcs
branch
from
d579d69
to
ca471c8
Compare
smarnach
force-pushed
the
gcs-cdn
branch
2 times, most recently
from
7c7f2ab
to
0d9bb73
Compare
smarnach
force-pushed
the
storage-interface-gcs
branch
from
ca471c8
to
df1fc5e
Compare
smarnach
force-pushed
the
gcs-cdn
branch
4 times, most recently
from
f4d08af
to
f1307b2
Compare
willkg
force-pushed
the
storage-interface-gcs
branch
from
afb7052
to
a324a95
Compare
smarnach
force-pushed
the
storage-interface-gcs
branch
from
e807085
to
ea0ff03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to use a global load balancer in front of a GCS storage bucket, since this will drastically reduce our egress costs. This means we need to be able to configure a public URL for symbol file access that's different than the bucket URL. This PR introduces a way to configure the public URL for each bucket. It also adds an nginx container simulating a load balancer to the devstack and runs all tests using storage against that configuration.
A positive side effect is that the nginx container makes downloading files from the host machine of the dev environment convenient again.