Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1906113: remove eliot references #2989

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Aug 9, 2024

This fixes a bunch of copy-paste errors and switches to statsd-centric language.

@willkg willkg force-pushed the willkg-bug-1906113-markus-fixes branch 3 times, most recently from ff1d911 to 9c29c64 Compare August 10, 2024 22:24
This fixes a bunch of copy-paste errors and switches to statsd-centric
language.

This also removes LogAllMetricsKeys which we don't use.
@willkg willkg force-pushed the willkg-bug-1906113-markus-fixes branch from 4c4ffae to 3149d97 Compare August 19, 2024 16:49
@willkg willkg marked this pull request as ready for review August 19, 2024 16:54
@willkg willkg requested a review from a team as a code owner August 19, 2024 16:54
@willkg willkg requested a review from relud August 19, 2024 16:55
_IS_MARKUS_SETUP = True


class LogAllMetricsKeys(BackendBase): # pragma: no cover
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this since we only allow documented metrics to be used via the RegisteredMetricsFilter.

@willkg willkg merged commit b9220aa into main Aug 19, 2024
2 checks passed
@willkg willkg deleted the willkg-bug-1906113-markus-fixes branch August 19, 2024 17:12
@willkg
Copy link
Contributor Author

willkg commented Aug 19, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants