From 6a3347f84309c20d4ea1dbd2e1a135d1eddc3e2d Mon Sep 17 00:00:00 2001 From: Stephanie Hobson Date: Wed, 31 Jul 2024 14:28:43 -0700 Subject: [PATCH] Convert buttons with data-link-type="download" into CTAs Fix #14062 --- .../banners/mobile/firefox-app-store.html | 4 +- .../banners/mobile/focus-app-store.html | 4 +- bedrock/base/templates/macros.html | 18 +- .../templates/firefox/all-unified.html | 2 +- .../firefox/browsers/chromebook.html | 4 +- .../firefox/browsers/mobile/index.html | 8 +- .../templates/firefox/enterprise/index.html | 20 +- .../includes/download-button-thanks.html | 4 +- .../firefox/includes/download-button.html | 19 +- .../firefox/includes/download-list.html | 4 +- .../includes/download-unsupported.html | 6 +- .../templates/firefox/includes/macros.html | 21 +- bedrock/firefox/templates/firefox/index.html | 6 +- bedrock/firefox/tests/test_helpers.py | 8 +- bedrock/firefox/tests/test_views.py | 15 +- .../mozorg/analytics-tests/ga-index.html | 4 +- ...ews.py::TestFirefoxGA::test_firefox_new_GA | 770 ++++++++++++++++++ media/css/firefox/browsers-products.scss | 2 +- media/js/base/core-datalayer.js | 2 +- media/js/base/mozilla-utils.js | 5 +- tests/pages/firefox/family/landing.py | 4 +- tests/unit/spec/base/core-datalayer.js | 2 +- tests/unit/spec/firefox/new/common/thanks.js | 2 +- 23 files changed, 863 insertions(+), 71 deletions(-) create mode 100644 firefox/tests/test_views.py::TestFirefoxGA::test_firefox_new_GA diff --git a/bedrock/base/templates/includes/banners/mobile/firefox-app-store.html b/bedrock/base/templates/includes/banners/mobile/firefox-app-store.html index 21b725143a3..5eb1b0d62d0 100644 --- a/bedrock/base/templates/includes/banners/mobile/firefox-app-store.html +++ b/bedrock/base/templates/includes/banners/mobile/firefox-app-store.html @@ -21,8 +21,8 @@

{{ ftl('banner-firefox-app-store-title') }}

{{ ftl('banner-firefox-app-store-free-google-play') }}

{{ ftl('banner-firefox-app-store-free-app-store') }}

- {{ ftl('ui-view') }} - {{ ftl('ui-view') }} + {{ ftl('ui-view') }} + {{ ftl('ui-view') }} diff --git a/bedrock/base/templates/includes/banners/mobile/focus-app-store.html b/bedrock/base/templates/includes/banners/mobile/focus-app-store.html index 5329b2818d8..ad78f47cf12 100644 --- a/bedrock/base/templates/includes/banners/mobile/focus-app-store.html +++ b/bedrock/base/templates/includes/banners/mobile/focus-app-store.html @@ -21,8 +21,8 @@

{{ ftl('banner-firefox-focus-app-store-title') }}

{{ ftl('banner-firefox-app-store-free-google-play') }}

{{ ftl('banner-firefox-app-store-free-app-store') }}

- {{ ftl('ui-view') }} - {{ ftl('ui-view') }} + {{ ftl('ui-view') }} + {{ ftl('ui-view') }} diff --git a/bedrock/base/templates/macros.html b/bedrock/base/templates/macros.html index f309f67f917..49ec1a191b6 100644 --- a/bedrock/base/templates/macros.html +++ b/bedrock/base/templates/macros.html @@ -48,7 +48,14 @@ {% macro google_play_button(class_name='', extra_data_attributes={}, extra_img_attributes={}, href=settings.GOOGLE_PLAY_FIREFOX_LINK_UTMS, id='', product='Firefox', target='') -%} {% set optional_img_attributes = {'alt': ftl('download-button-google-play'), 'width': '152', 'height': '45', 'l10n': True} %} {% do optional_img_attributes.update(extra_img_attributes) %} - + {{ resp_img( url='img/firefox/android/btn-google-play.png', srcset={ @@ -61,7 +68,14 @@ {% macro apple_app_store_button(class_name='', extra_data_attributes={}, extra_img_attributes={}, href=settings.APPLE_APPSTORE_FIREFOX_LINK, id='', product='Firefox', target='') -%} {% set optional_img_attributes = {'width': '152', 'height': '45'} %} - + {{ ftl('download-button-download-app-store') }} {%- endmacro %} diff --git a/bedrock/firefox/templates/firefox/all-unified.html b/bedrock/firefox/templates/firefox/all-unified.html index ab968cbfc95..243fce3575c 100644 --- a/bedrock/firefox/templates/firefox/all-unified.html +++ b/bedrock/firefox/templates/firefox/all-unified.html @@ -158,7 +158,7 @@

{{ ftl('firefox-all-choose-which-firefox') }}

{{ ftl('firefox-all-sorry-we-couldnt-find') }}

- + {{ ftl('download-button-download-now') }} diff --git a/bedrock/firefox/templates/firefox/browsers/chromebook.html b/bedrock/firefox/templates/firefox/browsers/chromebook.html index a8730a0cd5d..9419bf8ee63 100644 --- a/bedrock/firefox/templates/firefox/browsers/chromebook.html +++ b/bedrock/firefox/templates/firefox/browsers/chromebook.html @@ -49,13 +49,13 @@

{{ ftl('browsers-chromebook-get-firefox-browser') }}<

{{ ftl('browsers-chromebook-dropdown-copy') }}