Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter subscriptions page creates broken URL when left open for a period of time #13324

Closed
robhudson opened this issue Jun 29, 2023 · 1 comment
Assignees
Labels
Bug 🐛 Something's not working the way it should

Comments

@robhudson
Copy link
Member

robhudson commented Jun 29, 2023

Description

With the page open over a lunch break, then editing the form and submitting, I see 2 requests in my network panel...

  1. OPTIONS https://<basket-url>/news/user//
  2. POST https://<basket-url>/news/user//

Looks like the token expired since I opened the page and when I submitted the form.

Steps to reproduce

  1. Open https://www.mozilla.org/en-US/newsletter/existing/<token>/
  2. Wait about an hour
  3. Submit the form
@robhudson robhudson added the Bug 🐛 Something's not working the way it should label Jun 29, 2023
@alexgibson
Copy link
Member

alexgibson commented Jun 29, 2023

Yeah, looks like the cookie we set lasts for 1 hour. I'm not sure if we need to extend the duration (?), but we should probably fail more gracefully and redirect back to /recovery/ when it expires.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants