Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTM changes to reflect FF migration to ESR for Win 8.1 / macOS 10.14 #13376

Closed
4 tasks done
alexgibson opened this issue Jul 11, 2023 · 0 comments
Closed
4 tasks done

GTM changes to reflect FF migration to ESR for Win 8.1 / macOS 10.14 #13376

alexgibson opened this issue Jul 11, 2023 · 0 comments
Assignees
@stephaniehobson

Comments

@alexgibson
Copy link
Member

alexgibson commented Jul 11, 2023 •
edited by stephaniehobson
Loading

Description

This issue tracks updating our GTM config ahead of the changes in #13317, so that when Win 8.1 / macOS 10.14 visitors click ESR download buttons, those are now counted as ESR download events and not Firefox release channel downloads.

Changes:

  1. Added trigger: Click - Firefox Download Data Attribute - ESR (which can now fire from any page)
  2. Deleted trigger: Click - Firefox Download Data Attribute - ESR - Channel Page
  3. Deleted trigger: Click - Firefox Download Data Attribute - ESR - Developer Page
  4. Modified event: GA Event - Firefox Download (added ESR trigger as an exception)
  5. Modified event: GA Event - Firefox Download - ESR (mapped to ESR trigger)

Steps for review:

  1. Open each of the links below in GTM preview.
  2. Click download on the Release / Beta / Dev / Nightly buttons on each respective page, and verify the right events are fired for each button type.
  3. Add a class of fx-unsupported to the <html> element. You should now see an ESR download button in place of the regular download button for each page. Clicking an ESR download should fire an ESR download event, and not a download event for a different channel.

Success Criteria

  • GTM changes are approved and published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephaniehobson stephaniehobson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexgibson @stephaniehobson